Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang deleted branch fix-volume-light-tree from weizhen/blender 2024-03-25 18:51:06 +01:00
Weizhen Huang closed issue blender/blender#114634 2024-03-25 18:51:05 +01:00
Light tree can't sample correctly spotlight with volume (Blender 3.6 / 4.0 / 4.1 All versions of blender)
Weizhen Huang merged pull request blender/blender#119389 2024-03-25 18:51:04 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-25 18:49:41 +01:00
691dbe4267 Update test file and images
Weizhen Huang pushed to main at blender/blender-test-data 2024-03-25 18:49:29 +01:00
9ce3adf54d Cycles: update test file and images due to changes in light tree volume sampling
Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 18:25:20 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

It is trivial for NEE. For forward tracing, if we rely on volume_stack_sample_method(kg, state) then probably no additional extra path state is needed. Although this does sound quite hacky and…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 18:02:29 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

Attached is a scene where this PR has more noise with distance or MIS sampling. Not sure if this is realistic enough.

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 16:33:19 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

Ok I see your point, it is not directly related to equiangular/distance sampling, but light tree volume importance measure is biased towards equiangular sampling. Your suggestion would work when…

Weizhen Huang closed issue blender/blender#73184 2024-03-25 15:21:06 +01:00
Cycles Principled shader Fresnel glitches
Weizhen Huang commented on issue blender/blender#73184 2024-03-25 15:21:02 +01:00
Cycles Principled shader Fresnel glitches

Seems to be fixed already. From the attached file I see nothing out of the ordinary, EEVEE and Cycles also match well.

Weizhen Huang commented on issue blender/blender#72553 2024-03-25 15:12:22 +01:00
Cycles, inconsistent power units between mesh light and rectangle area light

The strength unit for mesh light is W/sr/m^2, integrated over the area and the hemisphere a factor of πA is expected, see blender/blender#108505 Can this…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 15:07:18 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

Effectively we are still reusing the same random number to sample the light position from volume segment and from position, but that doesn't seem to cause problem as I observed. It was using the…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 15:00:48 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

No. The change is that we determine the light to be sampled already in volume segment, not the light position. A new position would be sampled from the direct scattering position. Before this…

Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-25 13:10:52 +01:00
6c057c034d Merge remote-tracking branch 'origin' into fix-volume-light-tree
082b68fcb9 Cycles: improve equiangular sampling in volume
ab93a426a0 Fix assert from recent cleanup
2e8259e4d4 GPv3: Clean loose points in draw mode menu
7371b11bb5 Fix #119871: Window contents invalid on startup under Wayland & GNOME
Compare 88 commits »
Weizhen Huang deleted branch equiangular-valid-range from weizhen/blender 2024-03-25 13:02:17 +01:00
Weizhen Huang merged pull request blender/blender#119438 2024-03-25 13:02:14 +01:00
Cycles: improve equiangular sampling in volume
Weizhen Huang pushed to main at blender/blender 2024-03-25 13:02:14 +01:00
082b68fcb9 Cycles: improve equiangular sampling in volume
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-25 13:00:51 +01:00
35eb97037a Add test file
01620ce3fc Merge remote-tracking branch 'origin' into equiangular-valid-range
ab93a426a0 Fix assert from recent cleanup
2e8259e4d4 GPv3: Clean loose points in draw mode menu
7371b11bb5 Fix #119871: Window contents invalid on startup under Wayland & GNOME
Compare 88 commits »
Weizhen Huang pushed to main at blender/blender-test-data 2024-03-25 13:00:35 +01:00
00af9c6571 Cycles: add test file for various light types in volume
Weizhen Huang closed issue blender/blender#119855 2024-03-25 12:43:05 +01:00
Assert when stopping Cycles viewport render on macOS