Weizhen Huang weizhen
19 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang commented on issue blender/blender#119855 2024-03-25 12:43:02 +01:00
Assert when stopping Cycles viewport render on macOS

Fixed by 7e2d54e786de74eb2e96d8e32cf2db53e5f7112f

Weizhen Huang pushed to main at weizhen/.profile 2024-03-22 19:12:38 +01:00
b5073d003c Update reports/2024.md
Weizhen Huang commented on pull request blender/blender#119389 2024-03-22 17:46:49 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

@brecht this PR is also ready. But it includes changes from #119438 in order to test them together, so might be difficult to read. I can remove those changes, or we look at this PR later.

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 17:01:24 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

If we can not make the assumption anymore that the root index of the main tree is 0, and root_index is only used for traversing subtree here, I would rename it to subtree_index, or `subtree_roo…

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 16:12:34 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

@Alaska without light linking, the right child of the root node is always reserved for distant/backgrounds lights, even if there are not present in the scene, so 0 can't be the leaf. I do not…

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 16:04:01 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

@Sergey I am not sure if you misunderstood something or it was just typo, but without light linking 0 is the index of root node of the main tree, and the mesh lights have subtrees with non-zero…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-22 15:17:11 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

@blender-bot build +gpu

Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-22 15:08:00 +01:00
21af461948 Cleanup in comments
e95b884aef Cleanup to reduce noise
cd83b8f4bb Reduce storage
0f1ee83926 Add EMITTER_NONE
5425fb344c Use packed_float3 to save some space in LightSample
Compare 60 commits »
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-22 13:52:38 +01:00
ee241895a1 Cleanup to reduce noise
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-22 12:26:06 +01:00
e4c581e82a Reduce storage
9cad19ce69 Add EMITTER_NONE
e91d735613 Use packed_float3 to save some space in LightSample
Compare 3 commits »
Weizhen Huang commented on pull request blender/blender#119438 2024-03-21 19:49:15 +01:00
Cycles: improve equiangular sampling in volume

@brecht this patch is ready for review. Currently the ray segment is only computed when light tree is turned off, will compute also for light tree when #119389 is ready.

This patch basically…

Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-21 19:46:24 +01:00
59907df95d Merge remote-tracking branch 'origin' into equiangular-valid-range
575a5c0502 Fix #119744: Regression: Geometry Nodes: Default input not working
d8a89aa972 Compositor: Add MemoryBuffer constructor from size
f6657db713 Compositor: Add utility for nearest interpolation
20b614ab8e GPv3: Fill texture coordinates system
Compare 45 commits »
Weizhen Huang commented on pull request blender/blender#119438 2024-03-21 18:42:36 +01:00
Cycles: improve equiangular sampling in volume

@blender-bot build +gpu

Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-21 18:42:12 +01:00
0b839dfc8f Fix compilation error on Windows and Linux
Weizhen Huang commented on pull request blender/blender#119438 2024-03-21 18:34:07 +01:00
Cycles: improve equiangular sampling in volume

@blender-bot build +gpu

Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-21 18:33:18 +01:00
f326ebd116 Disable ray segment computation for light tree
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-21 18:16:25 +01:00
2a2ba7b375 Support distant light
f6036b6c59 Cleanup: add FIXME
Compare 2 commits »
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-21 16:23:41 +01:00
77af5b6d3e Fix sampling light from position when light tree fails
6ce8a019c7 Cleanup: remove condition in_volume
Compare 2 commits »
Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-20 18:21:26 +01:00
6e7000468a Merge branch 'equiangular-valid-range' into fix-volume-light-tree
39a8c16841 WIP: Fix correlated light samples in volume when using equiangular sampling
cd578c4b2e Refactor: make light_distribution/tree_sample only pick light
f368379856 Cleanup: add emitter_id entry in LightSample
df6a2b4edf Declare LightSample ls outside of ..direct_light()
Compare 305 commits »
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-20 18:07:15 +01:00
10e0cd6674 Cleanup: make equiangular coefficiensts struct
17bf75aa18 Cleanup: improve readability, remove unused variable
6d755747e4 Cleanup: remove todo, shuffle functions around
cee850ee8f Cleanup: remove unnecessary triangle light normal computation
2ffdcdca32 Fix numerical precision problem in ray cylinder intersection
Compare 59 commits »