Weizhen Huang weizhen
18 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 16:45:01 +01:00
e375b9714b Only color the outer ring and the sun rays
b315a3f795 Cleanup: delete space in CMake file
6f637475d0 Cleanup: remove RNA access when getting light color
ecc43b81ba Add option to show light color
d1a3ddd3ed WIP: draw light icon using the light color
Compare 67 commits »
Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:36:09 +01:00
Viewport: draw light icons using the light colors

I am following the comment I deleted for drawing the part, it was /* Light Icon */. Now we draw the inner circles and the outer circle separately, it's weird to call all of them "center". If…

Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:28:43 +01:00
Viewport: draw light icons using the light colors

Now this poor function only draws the light direction, not sure if we should rename it. I was considering adding a function that only draws the light direction because it is shared by other light types, but then other light types also draw clip start and end, so they are different.

Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:25:34 +01:00
Viewport: draw light icons using the light colors

I am not sure if coloring the light should be default. Currently it is disabled by default.

Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 16:21:46 +01:00
3ddb17c59e Only color the outer ring and the sun rays
Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-28 13:08:50 +01:00
e467a8c1db Refactor: Gizmo: transform RNA properties in light gizmos
257ddba6ae Refactor: Gizmo: update area light size via RNA instead of setting manually
edfe50f3bd Gizmo: display gizmo name in tooltip
599cbe0b04 Gizmo: enable undo for light gizmos
19ade197e2 Cleanup: use available #wmGizmoPropertyFnParams
Compare 119 commits »
Weizhen Huang pushed to main at blender/blender 2023-02-28 13:03:46 +01:00
5edca02d08 Fix cage2d gizmo setting uniform size when uniform scaling is required
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 11:49:15 +01:00
a0e073449a Cleanup: delete space in CMake file
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 11:47:26 +01:00
bfb06eedcb Cleanup: remove RNA access when getting light color
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-27 18:35:29 +01:00
733b30c6a3 Add option to show light color
Weizhen Huang created pull request blender/blender#105236 2023-02-27 11:27:22 +01:00
WIP: draw light icon using the light color
Weizhen Huang created branch colorful_light_icon in weizhen/blender 2023-02-27 11:15:00 +01:00
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-27 11:15:00 +01:00
f52a233129 WIP: draw light icon using the light color
16aab1508d Cleanup: comment out unused parameters from last commit
08af0f1204 Fix setting the active vertex color when assigning false
30db096cc8 Cleanup: quiet compiler warnings
dc08ff3c2e Cleanup: spelling in comments
Compare 10 commits »
Weizhen Huang pushed to main at blender/blender 2023-02-24 23:10:46 +01:00
6166dac3ee Gizmo: support scaling of light gizmos with zero size
Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-24 14:46:02 +01:00
db95b7226c Refactor: Gizmo: transform RNA properties in light gizmos
aa9edfb462 Refactor: Gizmo: update area light size via RNA instead of setting manually
95fbfba052 Gizmo: display gizmo name in tooltip
103419691a Gizmo: enable undo for light gizmos
6b89ce3c64 Cleanup: use available #wmGizmoPropertyFnParams
Compare 146 commits »
Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 16:18:29 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

Typo in the comment :DD

Weizhen Huang approved blender/blender#105022 2023-02-21 16:13:24 +01:00
Fix Light Tree option causing wrong renders on macOS AMD
Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:49:36 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

But according to scene.cpp the light manager is updated before the integrator? If light manager is updated after the integrator I agree it would be better to remove the other one. But yes if…

Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:16:03 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

I think this line can be deleted.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

I find it a bit confusing that there are two groups of getter/setters. The new transform_set_fn could modify the value, and I don't want to drop the const specifier for value_set_fn. Or could there be better function names?