Instead of renaming Coat to Intensity, I'm thinking maybe we can have a representative socket for the panel so that you see the value even when it's collapsed, no additional Intensity bar needed.…
Now that we have panel, I think the nodes should be renamed because otherwise it would be too verbose. For example all the coat-related stuff can have the coat prefix removed, and coat and be…
Sergey said the convention in Blender is _sq, I have that in ray_sphere_intersect(), and am trying to name all the newly added variables with that suffix. But we have a lot mixed convention…
Would be better yes! This comes from an early iteration where I was thinking r can mean both reflection and refraction, but the reflection angle is not really needed here, it always equals to…
In bsdf_eval() the *pdf is initialized with zero, so it's not necessary to assign zero to *pdf again.
I was thinking whether we should remove such assignment in all the bsdf_xxx_eval().…
I don't really understand how it's working. With all these continue, return and do {} while (closure == nullptr) I find the flow quite hard to follow.
I rewrote EEVEE principled BSDF #111754, and adjusted the part in this pull request so that it uses coat IOR instead of the default 1.5 in the merge commit 445464e5f2999a727d0795b05e0519b73a75b090
Not sure about 7f28729e13, the transition seems smoother without the change. Probably should fix OSL instead.