Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang pushed to principled-specular-color at weizhen/blender 2023-08-23 19:59:27 +02:00
bb856bccaa WIP: change specular tint input from float to color
f6400c7f7f Replace Dielectric Tint by Generalized Schlick
fa09ffc585 Document 110239: How callbacks work on Operator properties
668b31c5d8 Outliner: Port layer collection elements to new tree-element code design
110eb666ca Fix #111439: liboverride object cannot be made local from 3DView, if it has a local parent.
Compare 10 commits »
Weizhen Huang deleted branch concentric_sampling from weizhen/blender 2023-08-23 17:25:36 +02:00
Weizhen Huang merged pull request blender/blender#109774 2023-08-23 17:25:35 +02:00
Cycles: use low-distortion mapping when sampling cone and hemisphere
Weizhen Huang pushed to main at blender/blender 2023-08-23 17:25:34 +02:00
1284e98ab8 Cycles: use low-distortion mapping when sampling cone and hemisphere
Weizhen Huang commented on pull request blender/blender#111292 2023-08-23 17:14:14 +02:00
Cycles Light Tree: Add case for when an emitter is not selected

Hi, turns out that the selected emitter can be -1 because all the importance[1](min_importance) are zero, which is allowed at the line you changed, so the tests failed. The problem is that…

Weizhen Huang deleted branch fix-nan-importance from weizhen/blender 2023-08-23 16:09:14 +02:00
Weizhen Huang pushed to main at blender/blender 2023-08-23 16:09:14 +02:00
c076202e23 Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang merged pull request blender/blender#111428 2023-08-23 16:09:13 +02:00
Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang pushed to concentric_sampling at weizhen/blender 2023-08-23 16:03:10 +02:00
f37946bcfb Apply function name changes in recent bsdf_sheen.h
5265d3d166 Merge branch 'main' into concentric_sampling
45f3426559 Fix: UserDef_Experimental padding
85b02b893a Workbench-Next: Enabled by default
d732478574 Cleanup: Geometry Nodes: Unnecessary components to check
Compare 1320 commits »
Weizhen Huang pushed to fix-nan-importance at weizhen/blender 2023-08-23 15:40:41 +02:00
5eedff0adf Also cover cases when NaN is not caused by invalid normals
a05a67b6a1 Fix illegal address error in Cycles Light Tree when no emitter is selected
45f3426559 Fix: UserDef_Experimental padding
85b02b893a Workbench-Next: Enabled by default
d732478574 Cleanup: Geometry Nodes: Unnecessary components to check
Compare 6 commits »
Weizhen Huang created pull request blender/blender#111428 2023-08-23 13:36:25 +02:00
Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang created branch fix-nan-importance in weizhen/blender 2023-08-23 13:35:32 +02:00
Weizhen Huang pushed to fix-nan-importance at weizhen/blender 2023-08-23 13:35:32 +02:00
9423c65b49 Fix illegal address error in Cycles Light Tree when no emitter is selected
3cd14df7d8 Revert "Fix illegal address error in Cycles Light Tree when no emitter is selected"
beaf4854b1 Fix #110328: Clay Strip symmetry does not mirror rotation
7bb693581f UI: Move asset shelf out of experimental
206ab6437b Fix illegal address error in Cycles Light Tree when no emitter is selected
Compare 10 commits »
Weizhen Huang pushed to main at blender/blender 2023-08-23 12:44:35 +02:00
3cd14df7d8 Revert "Fix illegal address error in Cycles Light Tree when no emitter is selected"
Weizhen Huang merged pull request blender/blender#111292 2023-08-23 11:54:28 +02:00
Cycles Light Tree: Add case for when an emitter is not selected
Weizhen Huang pushed to main at blender/blender 2023-08-23 11:54:28 +02:00
206ab6437b Fix illegal address error in Cycles Light Tree when no emitter is selected
Weizhen Huang approved blender/blender#111292 2023-08-23 11:52:10 +02:00
Cycles Light Tree: Add case for when an emitter is not selected

You are right, if the normal is wrong it's still visible as an artefact, this patch is just to cover illegal address error, so I think it's fine. Thanks!