Habib Gahbiche zazizizou
  • Joined on 2015-02-21
Habib Gahbiche pushed to main at blender/blender-test-data 2024-06-20 22:15:53 +02:00
b804832f16 Tests: Added mesh operator quads_convert_to_tris (#3)
Habib Gahbiche merged pull request blender/blender-test-data#3 2024-06-20 22:15:51 +02:00
Updated operators.blend file for quads_convert_to_tris operator test
Habib Gahbiche suggested changes for blender/blender#123286 2024-06-19 17:44:09 +02:00
Operator tests: Adding test for quads_convert_to_tris operator.

The patch looks good, just some very small details to correct before it can get merged:

Habib Gahbiche commented on pull request blender/blender#123286 2024-06-19 17:42:36 +02:00
Operator tests: Adding test for quads_convert_to_tris operator.

Coding style: inconsistent format. See https://developer.blender.org/docs/handbook/tooling/clangformat/ for how to format your code automatically to match

Habib Gahbiche commented on pull request blender/blender#123286 2024-06-16 12:26:22 +02:00
Operator tests: Adding test for quads_convert_to_tris operator.

Thanks for the patch! I will test later, but the code looks fine :)

Regarding the blend file you should create a PR in the test repository to update the test files, see https://projects.blender

Habib Gahbiche commented on issue blender/blender#84999 2024-06-12 21:26:59 +02:00
Add Operator tests

@Dario-San I think it always makes sense to extend the automated testing framework with more test cases, so your contribution would definitely be useful. I am willing to help and review your…

Habib Gahbiche commented on issue blender/blender#122967 2024-06-10 00:05:05 +02:00
Blender Compositor Scale node Render size Fit and Crop Bug

I think these are also expected. If you render with F12 both CPU and GPU results are consistent with 4.1. The behavior of crop is not much different than regular scaling, where the size of the new…

Habib Gahbiche commented on issue blender/blender#122967 2024-06-09 22:59:39 +02:00
Blender Compositor Scale node Render size Fit and Crop Bug

Thanks for the report! :)

This is indeed expected, because the compositor CPU backend changed in 4.2. You should see the same contour when you click on the viewer node. But when you hit F12…

Habib Gahbiche suggested changes for blender/blender#119902 2024-06-09 20:24:06 +02:00
WIP: Compositor: Add interpolation option to scale node

Hi, thanks for the patch :) Now that blender/blender#119603 is merged, we can move forward with this patch.

Habib Gahbiche commented on pull request blender/blender#119902 2024-06-09 20:24:05 +02:00
WIP: Compositor: Add interpolation option to scale node

We should really use a proper enum now that we are converting from one enum of sampling to another.

Habib Gahbiche commented on pull request blender/blender#119902 2024-06-09 20:24:04 +02:00
WIP: Compositor: Add interpolation option to scale node

I think using a proper struct for the scale node makes sense, but I think versioning might be needed. Have you checked if node trees from older files can be loaded and executed properly?

Habib Gahbiche pushed to com-vis-render-size at zazizizou/blender 2024-06-09 14:20:14 +02:00
5da3e39506 Renamings
Habib Gahbiche pushed to com-vis-render-size at zazizizou/blender 2024-06-09 13:59:31 +02:00
14a77d58e8 Simplify approach: Add text info and remove domain size.
6774f48ac4 Merge remote-tracking branch 'origin/main' into com-vis-render-size
79244e5632 Merge branch 'blender-v4.2-release'
965a138671 Fix #121025: Edge Slide not picking the correct reference edge
efd3c4b3c9 Fix #122896: Knife snap to edge fails when a vertex is behind the viewer
Compare 1914 commits »
Habib Gahbiche commented on pull request blender/blender#122693 2024-06-08 13:18:08 +02:00
Compositor: gizmo for box mask

Is it possible to have gizmos in image editor as well? Would be amazing for those who don't use backdrop

I think it makes sense and I'm interested in implementing that also, but I have no…

Habib Gahbiche deleted branch com-rm-tiled-center from zazizizou/blender 2024-06-04 21:15:36 +02:00
Habib Gahbiche merged pull request blender/blender#122639 2024-06-04 21:15:31 +02:00
Compositor: remove viewer cross hair setting Tiled priority