Habib Gahbiche zazizizou
  • Joined on 2015-02-21
Habib Gahbiche created branch com-split-node in zazizizou/blender 2023-10-29 10:08:21 +01:00
Habib Gahbiche commented on pull request blender/blender#111150 2023-10-26 06:46:04 +02:00
Speedup classic Kuwahara filter by summed area table

Are there locks down the the road in the get_elem perhaps which gets in a way of better parralelism?

It looks like memory access is the bottleneck. read_elem_checked is the function…

Habib Gahbiche commented on pull request blender/blender#111150 2023-10-26 06:10:14 +02:00
Speedup classic Kuwahara filter by summed area table

No specific reason, but it doesn't make a difference here because there is a single assert per test. I can update it in a later patch for clarity

Habib Gahbiche commented on pull request blender/blender#111150 2023-10-22 20:00:26 +02:00
Speedup classic Kuwahara filter by summed area table

Some findings from profiling:

  • SAT multithreaded implementation is 30-40% faster than single threaded SAT. On my machine, fullframe is now 3-4x slower than GPU
  • SAT operation is the bottleneck…
Habib Gahbiche pushed to com-kuwahara-sat at zazizizou/blender 2023-10-22 19:43:31 +02:00
6b46a68886 SAT is now always computed. Keep naive implementation for small kernel sizes for better accuracy
689f5fde28 Merge remote-tracking branch 'origin/main' into com-kuwahara-sat
fad4cffc41 More compact code for threading::parallel_for
9453031730 GPv3: Instance on Points
eab204b0a4 Fix: GPv3: Radial brush size control broken
Compare 1391 commits »
Habib Gahbiche commented on pull request blender/blender#111150 2023-10-21 21:49:20 +02:00
Speedup classic Kuwahara filter by summed area table

Will do, thanks for the tip :)

Habib Gahbiche commented on pull request blender/blender#111150 2023-09-23 14:42:48 +02:00
Speedup classic Kuwahara filter by summed area table

Using TBB was not much faster than openMP but multithreading in general helped in reducing the error (see updated images in description).

As agreed, I removed the fast. The filter still…

Habib Gahbiche pushed to com-kuwahara-sat at zazizizou/blender 2023-09-23 14:35:08 +02:00
360f2a5c6a Invert condition to reduce indentation
84bdba3922 Fix build error after merge
5240765672 Merge remote-tracking branch 'origin/main' into com-kuwahara-sat-zazizizou
1fda4efc22 Multi-threaded SAT implementation. Offset and mean not needed anymore
652aab0b31 Fix: Swapped icons in node tool header popover
Compare 469 commits »
Habib Gahbiche commented on pull request blender/blender#111150 2023-09-23 14:33:32 +02:00
Speedup classic Kuwahara filter by summed area table

As discussed, I tried this and it didn't work. The reason is the small differences of 0.2 - 0.3 (2x - 3x actual mean) cause very large differences in the squared SAT, making it asymmetric and…

Habib Gahbiche commented on pull request blender/blender#111150 2023-09-16 15:56:13 +02:00
Speedup classic Kuwahara filter by summed area table

Option will be removed.

Habib Gahbiche commented on pull request blender/blender#111150 2023-09-16 15:55:24 +02:00
Speedup classic Kuwahara filter by summed area table

As discussed in the meeting, my concern was using SingleThreadedOperation for a multi-threaded execution. I will upload a patch using TBB.

Habib Gahbiche deleted branch com-kuwahara-unify-alpha from zazizizou/blender 2023-09-16 15:50:36 +02:00
Habib Gahbiche pushed to main at blender/blender 2023-09-16 15:50:35 +02:00
e621b7a621 Compositor: Kuwahara filter: consider alpha channel.
Habib Gahbiche merged pull request blender/blender#112199 2023-09-16 15:50:34 +02:00
Compositor: Kuwahara filter: consider alpha channel.
Habib Gahbiche pushed to com-kuwahara-unify-alpha at zazizizou/blender 2023-09-14 21:10:57 +02:00
0a9fc1576c Merge remote-tracking branch 'origin/main' into com-kuwahara-unify-alpha
1690dbecf2 Do not consider alpha for variance computation
64bd2091cf Realtime Compositor tests: enable keying tests.
4086ef986c Fix #112374: loading reference/background images filters out movies
2ec2e52a90 UI: Theme: Allow transparency when editing text in widgets
Compare 144 commits »
Habib Gahbiche deleted branch com-enable-keying-gpu-tests from zazizizou/blender 2023-09-14 20:27:41 +02:00
Habib Gahbiche merged pull request blender/blender#112198 2023-09-14 20:27:40 +02:00
Realtime Compositor tests: enable keying tests.