Habib Gahbiche zazizizou
  • Joined on 2015-02-21
Habib Gahbiche pushed to com-realtime-regression-test at zazizizou/blender 2023-08-12 12:36:42 +02:00
4ff6562f55 add libmv as dependency to realtime compositor test + use single folder for compositor blend tests
d054a0e45e Deactivate WITH_COMPOSITOR_REALTIME_TEST for developer config
Compare 2 commits »
Habib Gahbiche commented on pull request blender/blender#109878 2023-08-11 10:25:26 +02:00
Realtime Compositor: add regression tests

Sounds good to me, thanks!

Habib Gahbiche commented on pull request blender/blender#109878 2023-08-11 10:25:25 +02:00
Realtime Compositor: add regression tests

Sounds good to me, thanks!

Habib Gahbiche commented on pull request blender/blender#109878 2023-08-11 10:13:02 +02:00
Realtime Compositor: add regression tests

@Sergey @fclem Thanks for looking into this !

For me it's important to run these tests for each patch with the compositor. If they are not active in buildbot by default then it doesn't make…

Habib Gahbiche deleted branch com-cleanup-todo from zazizizou/blender 2023-08-07 18:30:09 +02:00
Habib Gahbiche merged pull request blender/blender#110856 2023-08-07 18:30:06 +02:00
Cleanup: Compositor: Remove outdated TODO
Habib Gahbiche pushed to main at blender/blender 2023-08-07 18:30:06 +02:00
2f907a0b53 Cleanup: Compositor: Remove outdated TODO
Habib Gahbiche created pull request blender/blender#110856 2023-08-06 16:11:32 +02:00
Cleanup: Compositor: Remove outdated TODO
Habib Gahbiche pushed to com-cleanup-todo at zazizizou/blender 2023-08-06 16:06:41 +02:00
93410bebb9 Merge remote-tracking branch 'origin/main' into com-cleanup-todo
5ac026c23a EEVEE-Next: Irradiance Volume validity weighting
8b8fe49d34 License headers: add SPDX-FileCopyrightText
845a5146e7 Cleanup: avoid term '_len' for buffer size
9e3dc02bed Cleanup: naming consistency for find functions
Compare 10 commits »
Habib Gahbiche created branch com-cleanup-todo in zazizizou/blender 2023-08-06 16:06:41 +02:00
Habib Gahbiche commented on pull request blender/blender#109878 2023-08-06 15:42:13 +02:00
Realtime Compositor: add regression tests

@OmarEmaraDev I added matte and distortion tests and identified a few more crashing and failing tests. For now they are disabled but I want to investigate further. I am still not able to run…

Habib Gahbiche pushed to com-realtime-regression-test at zazizizou/blender 2023-08-06 15:35:03 +02:00
c97abf557c add matte and distort test cases
e9e14c12b7 Merge remote-tracking branch 'origin/main' into com-realtime-regression-test
344ba9691b WM: use repr for WM_OT_context_toggle_enum
53e6803977 Cleanup: check for "BaseException" instead of "Exception"
9f5be2a861 Cleanup: quiet pylint warnings using BaseException
Compare 235 commits »
Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:39:26 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

Yes I meant eccentricity sorry. I think I understand what it means, I was just thinking how hard it would be from a user's perspective. I'm ok with the naming if most users can understand the…

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:39:24 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

Yes I meant eccentricity sorry. I think I understand what it means, I was just thinking how hard it would be from a user's perspective. I'm ok with the naming if most users can understand the…

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:32:17 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

Is it possible to rename radius to size in code then? I found it a bit hard to navigate code if variables get renamed from UI to implementation

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:28:51 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

@OmarEmaraDev Results actually look very good. Your solution also solves a few issues we have with CPU implementation. Nicely done! :)

I did a few tests and looked at the code and have a few…

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:17:44 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

typo?

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:12:37 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

For me it's a bit hard to guess the effect of the parameter without reading documentation. Is preserve edge a better name maybe?

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 16:09:45 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

radius is actually called size in UI, right? I think we should unify naming here. radius is also a fitting name for the classic variation so I don't mind renaming the UI parameter to radius.

Habib Gahbiche commented on pull request blender/blender#110786 2023-08-05 14:39:37 +02:00
Realtime Compositor: Implement Anisotropic Kuwahara

I think sharpness and smoothing are the same thing from a user's perspective. Ideally we shouldn't duplicate it, even if GPU and CPU implementations are different.