@OmarEmaraDev I added matte
and distortion
tests and identified a few more crashing and failing tests. For now they are disabled but I want to investigate further.
I am still not able to run…
Yes I meant eccentricity sorry. I think I understand what it means, I was just thinking how hard it would be from a user's perspective. I'm ok with the naming if most users can understand the…
Yes I meant eccentricity sorry. I think I understand what it means, I was just thinking how hard it would be from a user's perspective. I'm ok with the naming if most users can understand the…
Is it possible to rename radius to size in code then? I found it a bit hard to navigate code if variables get renamed from UI to implementation
@OmarEmaraDev Results actually look very good. Your solution also solves a few issues we have with CPU implementation. Nicely done! :)
I did a few tests and looked at the code and have a few…
For me it's a bit hard to guess the effect of the parameter without reading documentation. Is preserve edge
a better name maybe?
radius
is actually called size
in UI, right? I think we should unify naming here. radius
is also a fitting name for the classic variation so I don't mind renaming the UI parameter to radius.
I think sharpness and smoothing are the same thing from a user's perspective. Ideally we shouldn't duplicate it, even if GPU and CPU implementations are different.