Alexandre-Cardaillac
  • Joined on 2024-04-17
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-11-14 02:06:32 +01:00
Cycles: Additional scattering phase functions

@Alexandre-Cardaillac Thanks a lot for the info. The link you posted only plot between n = 1 ~ 1.2, is that a more reasonable range? Or it could be higher? Another question I have is, is…

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-11-13 03:41:36 +01:00
Cycles: Additional scattering phase functions

@Alexandre-Cardaillac May I ask what this IOR is in Fournier-Forand? The default value of 1.33 made me think it's the IOR of water, but the value I found in the paper you posted is 1.09, and…

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-09-30 18:47:19 +02:00
Cycles: Additional scattering phase functions

A lot have changed since my last commit on this PR, is there anything I can do to help?

88e4ee22ba Cycles: Fix cycles_volume_cpu test
f2e13017de Cycles: Handle FF phase singularity
d55ce20dfd Cycles: Remove new volume density mode
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-09-19 03:08:23 +02:00
Cycles: Additional scattering phase functions

no it does not have a physical interpretation, and is a very rare case. I'll add the Taylor expansion you proposed, thanks.

6fdf884d7a Cycles: Remove Draine phase function
f0ab12e6da Cycles: Fix typos/comments/errors
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-09-17 05:17:50 +02:00
Cycles: Additional scattering phase functions

Would make_phase_wo() be more appropriate?

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-09-17 03:39:24 +02:00
Cycles: Additional scattering phase functions

It makes it easier and more intuitive to model existing volumes with known physical measurements. But yes, it is possible to do a mapping, setting the density to the highest density among the…

b483da9307 Cycles: Fix compile error
fc6909cd2a Merge branch 'main' into fournier-forand-phase-function
6bd515e0d2 Fix: USD: Use correct data type for UsdPreviewSurface normal input
a0df365b77 UI: Add Snapping to Docking Status Bar Entries
503cb7bfee UI: Correction to Space Image image_space_name_get
13eb41959e Fix: UI: Editor window(s) title update when using interactive docking
Compare 2731 commits »
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-20 06:39:18 +02:00
Cycles: Additional scattering phase functions

@weizhen @mod_moder , I updated the PR description as requested to include more details and examples. The videos are not the best quality but they sort of show how is the main parameter of each…

40591c1eb9 Cycles: Remove extra subtypes of volume shader parameters
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-16 09:21:32 +02:00
Cycles: Additional scattering phase functions

Some code-level comments.

I've skipped the actual sampling/evaluation functions for now, I'll look at them later.

Three more points:

  • We don't need the LCG, you can just decide…
d3a9d06cd5 Cycles: Fix cycles_osl_cpu test
2efbb42cf7 Cycles: Add templates to eval and sample phase functions
3e52650d8b Cycles: Add OSL closure for each phase function
66e30f7cd7 Cycles: Add CLOSURE_ID to each volume phase and separate phase params
22eec5e294 Cycles: Remove LCG dependency to volume scatter
4a2b77c0b0 Cycles: Rename IoR to IOR
Compare 5 commits »
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-15 07:29:49 +02:00
Cycles: Additional scattering phase functions

Do you mean I should add a define for each new input?

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-06-27 02:28:16 +02:00
Cycles: Additional scattering phase functions

For user side, would be good if description will also contains examples of the added options on render (not only UI changes).

@mod_moder could you precise what description your are talking…