Alexandre-Cardaillac
0 Followers · 0 Following
  • Joined on 2024-04-17
Repositories
1
 Projects Public Activity Starred Repositories
b483da9307 Cycles: Fix compile error
fc6909cd2a Merge branch 'main' into fournier-forand-phase-function
6bd515e0d2 Fix: USD: Use correct data type for UsdPreviewSurface normal input
a0df365b77 UI: Add Snapping to Docking Status Bar Entries
503cb7bfee UI: Correction to Space Image image_space_name_get
13eb41959e Fix: UI: Editor window(s) title update when using interactive docking
Compare 2731 commits »
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-20 06:39:18 +02:00
Cycles: Additional scattering phase functions

@weizhen @mod_moder , I updated the PR description as requested to include more details and examples. The videos are not the best quality but they sort of show how is the main parameter of each…

40591c1eb9 Cycles: Remove extra subtypes of volume shader parameters
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-16 09:21:32 +02:00
Cycles: Additional scattering phase functions

Some code-level comments.

I've skipped the actual sampling/evaluation functions for now, I'll look at them later.

Three more points:

  • We don't need the LCG, you can just decide…
d3a9d06cd5 Cycles: Fix cycles_osl_cpu test
2efbb42cf7 Cycles: Add templates to eval and sample phase functions
3e52650d8b Cycles: Add OSL closure for each phase function
66e30f7cd7 Cycles: Add CLOSURE_ID to each volume phase and separate phase params
22eec5e294 Cycles: Remove LCG dependency to volume scatter
4a2b77c0b0 Cycles: Rename IoR to IOR
Compare 5 commits »
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-08-15 07:29:49 +02:00
Cycles: Additional scattering phase functions

Do you mean I should add a define for each new input?

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-06-27 02:28:16 +02:00
Cycles: Additional scattering phase functions

For user side, would be good if description will also contains examples of the added options on render (not only UI changes).

@mod_moder could you precise what description your are talking…

Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-06-26 08:11:19 +02:00
Cycles: Additional scattering phase functions

It would be nice if you

  1. Add a reference link (paper, textbook, webpage, whatever) to each phase function you implemented, so that we know what these equations are based on and it will be…
Alexandre-Cardaillac commented on pull request blender/blender#123532 2024-06-26 08:08:46 +02:00
Cycles: Additional scattering phase functions

I recently came across this paper: https://research.nvidia.com/labs/rtr/approximate-mie/

Might make sense to implement that as well?

Thank you for the suggestion, it seems relevant to…

cd94b97e63 Cycles: Add better phase descriptions and references
87dbc5e9e2 Cycles: Add Draine and Draine-Henyey-Greenstein phase functions
3e7e3fb1ab Cycles: Fix cycles_volume_cpu tests
Compare 3 commits »
Alexandre-Cardaillac created pull request blender/blender#123532 2024-06-21 08:28:03 +02:00
Additional scattering phase functions
2c9da6df0a Cycles: Add Double Henyey-Greenstein and Rayleigh phase functions
46a87a0105 Cycles: Fix volume OSL with new phase functions
d1ff81593f Cycles: Add Fournier-Forand phase function and channel-wise densities
Compare 3 commits »
Alexandre-Cardaillac created repository Alexandre-Cardaillac/blender 2024-06-18 07:12:35 +02:00