AresDeveaux
  • Joined on 2023-03-03
AresDeveaux commented on pull request blender/blender#106517 2023-04-18 03:48:32 +02:00
Animation: blend to infinity slider

'segment->start_index + segment->length >= fcu->totvert - 1' to segment->start_index + segment->length > fcu->totvert and segment->start_index <= 1 to segment->start_index == 0. I tried it and it…

AresDeveaux commented on pull request blender/blender#106517 2023-04-18 03:47:13 +02:00
Animation: blend to infinity slider

your suggestion of adding continue to the condition for the warning works, but made me realize 2 things:

1.- I need to split the warning into two possibilities. One when we don't have two…

AresDeveaux commented on pull request blender/blender#106517 2023-04-18 03:45:44 +02:00
Animation: blend to infinity slider

Hey, Sorry I didn't check for those obvious changes I should have done when I took some lines outside from the loops.

In regard to changing 'segment->start_index + segment->length >= fcu->totver…

AresDeveaux pushed to blend_to_infinity_slider at AresDeveaux/blender 2023-04-18 03:45:34 +02:00
5761ec49be cleaned the code a bit
AresDeveaux commented on pull request blender/blender#106521 2023-04-17 18:28:21 +02:00
Animation: shear left slider
What are the future plans for this operator? Would it ever need to be able to sheer the other side as well?

Maybe my comment was misleading. We are using both sides of the slider.

AresDeveaux pushed to scale_average_slider at AresDeveaux/blender 2023-04-14 23:00:24 +02:00
abbed04c71 variable name change
AresDeveaux commented on pull request blender/blender#106520 2023-04-14 22:48:40 +02:00
Animation: time offset slider

I added the lines you suggested to avoid memory leaks, and when compiling I get this message in regard to one of the lines:

warning: ignoring return value of function declared with…
AresDeveaux pushed to push_pull_slider at AresDeveaux/blender 2023-04-14 21:48:26 +02:00
33258ccd03 variable name change
AresDeveaux commented on pull request blender/blender#106525 2023-04-14 21:43:18 +02:00
Animation: ease-ease slider

I'm not too sure about the name of this slider, any suggestion is welcome.

AresDeveaux pushed to ease_ease_slider at AresDeveaux/blender 2023-04-14 21:42:10 +02:00
cf3a822744 fixed a variable name according to the feedback received on blend_ease_slider
AresDeveaux commented on pull request blender/blender#106521 2023-04-14 21:36:21 +02:00
Animation: shear left slider

Well, I pushed the typo correction just in case.

AresDeveaux pushed to shear_left_slider at AresDeveaux/blender 2023-04-14 21:35:23 +02:00
174ddcbeb5 fixed minor change on a description
AresDeveaux pushed to shear_right_slider at AresDeveaux/blender 2023-04-14 21:34:45 +02:00
e55625d351 fixed minor change on a description
AresDeveaux commented on pull request blender/blender#106520 2023-04-14 21:27:03 +02:00
Animation: time offset slider

Why can I compile it? do I need to set something I haven't for make?

When you say C doesn't allow variable length array, I'm not sure I follow. I thought by declaring an array with a fixed…

AresDeveaux commented on pull request blender/blender#106521 2023-04-14 20:59:20 +02:00
Animation: shear left slider

I see you approved, did you change the typo? don't know if I should publish the error correction and ask for a new review.

AresDeveaux commented on pull request blender/blender#106519 2023-04-14 20:31:24 +02:00
Animation: blend to ease slider

addressed your notes and also another to simplify that came from another slider.

AresDeveaux pushed to blend_to_ease_slider at AresDeveaux/blender 2023-04-14 20:29:36 +02:00
c17a5dda7f addressed Christoph's notes to change variable name and simplify
AresDeveaux commented on pull request blender/blender#106518 2023-04-14 19:45:28 +02:00
Animation: blend offset slider

I simplified the code as per your suggestions.

AresDeveaux commented on pull request blender/blender#106517 2023-04-14 19:28:06 +02:00
Animation: blend to infinity slider

I simplified the code using your suggestions and even found other places to implement the same to simplify it even more.

I added the warning but it is not working right at the moment. I added…

AresDeveaux pushed to blend_to_infinity_slider at AresDeveaux/blender 2023-04-14 19:11:11 +02:00
a0e005c3f6 added warning