Animation: blend to ease slider #106519

AresDeveaux · 2023-04-04T05:54:13+02:00

AresDeveaux commented

2023-04-04 05:54:13 +02:00

First-time contributor

New operator for the slider tool in the Graph Editor.

It blends selected keyframes from the current state to an ease-in or ease-out curve. Because it is a blend, the animator can choose how much the ease can affect the animation already in the keys.

It uses the structure already created by @ChrisLend. The main functionality chancge is in 'keyframes_general.c', the rest for the most part just follows what hi did.

New operator for the slider tool in the Graph Editor. It blends selected keyframes from the current state to an ease-in or ease-out curve. Because it is a blend, the animator can choose how much the ease can affect the animation already in the keys. It uses the structure already created by @ChrisLend. The main functionality chancge is in 'keyframes_general.c', the rest for the most part just follows what hi did.

blend_to_ease_slider.gif

1.2 MiB

AresDeveaux added 5 commits 2023-04-04 05:54:24 +02:00

Added functions 9d1c03966b

change names of the functions to include "to" and fixed one functions that was actually the wrong one cb45fcb306

changed some variables to constant 6ddc483989

changed some variables declaration 1ef18cc8c7

Fixed some formating 181c5389eb

AresDeveaux referenced this pull request

2023-04-06 20:14:34 +02:00

Animation: Extra operators for the graph editor's sliders #106639

Nate Rupsis added the

Module

Animation & Rigging

label 2023-04-06 20:58:40 +02:00

Nate Rupsis added this to the Animation & Rigging project 2023-04-06 20:58:46 +02:00

AresDeveaux changed title from ~~WIP: Animation&Rigging: blend_to_ease_slider~~ to Animation: blend to ease slider

2023-04-10 05:34:34 +02:00

AresDeveaux added 1 commit 2023-04-11 01:05:06 +02:00

simplified the function and fixed an error 1e5227c635

Christoph Lendenfeld requested changes 2023-04-13 12:15:18 +02:00

Christoph Lendenfeld left a comment

really nice! Good job on making the s_curve function. could potentially be used in ease_fcurve_segment as well

Just some small tweaks

really nice! Good job on making the s_curve function. could potentially be used in `ease_fcurve_segment` as well Just some small tweaks

source/blender/editors/animation/keyframes_general.c Outdated

						
				@ -494,0 +497,4 @@

				   * or horizontaly. The range of the curve used is from 0 to 1 on "x" and "y" so we can scale it

				   * (width and height) and move it (xshift and y yshift) to crop the part of the curve we need.

				   * Slope determins how curvy the shape is */

				  float curve = height * pow((x - xshift), slope) /

Christoph Lendenfeld commented

2023-04-13 12:14:41 +02:00

this could be renamed to y or curve_y
after all it's only a single point and not a whole curve

this could be renamed to `y` or `curve_y` after all it's only a single point and not a whole curve

source/blender/editors/animation/keyframes_general.c Outdated

						
				@ -494,0 +529,4 @@

				  const bool slider_right_side = factor > 0.5;

				  /* The factor goes from 0 to 1, but for this tool it needs to go from -1 to 1. */

				  const float long_factor = factor * 2 - 1;