Animation: blend to ease slider #106519

Closed
AresDeveaux wants to merge 11 commits from AresDeveaux/blender:blend_to_ease_slider into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
First-time contributor

New operator for the slider tool in the Graph Editor.

It blends selected keyframes from the current state to an ease-in or ease-out curve. Because it is a blend, the animator can choose how much the ease can affect the animation already in the keys.

It uses the structure already created by @ChrisLend. The main functionality chancge is in 'keyframes_general.c', the rest for the most part just follows what hi did.

New operator for the slider tool in the Graph Editor. It blends selected keyframes from the current state to an ease-in or ease-out curve. Because it is a blend, the animator can choose how much the ease can affect the animation already in the keys. It uses the structure already created by @ChrisLend. The main functionality chancge is in 'keyframes_general.c', the rest for the most part just follows what hi did.
AresDeveaux added 5 commits 2023-04-04 05:54:24 +02:00
Nate Rupsis added the
Module
Animation & Rigging
label 2023-04-06 20:58:40 +02:00
Nate Rupsis added this to the Animation & Rigging project 2023-04-06 20:58:46 +02:00
AresDeveaux changed title from WIP: Animation&Rigging: blend_to_ease_slider to Animation: blend to ease slider 2023-04-10 05:34:34 +02:00
AresDeveaux added 1 commit 2023-04-11 01:05:06 +02:00
Christoph Lendenfeld requested changes 2023-04-13 12:15:18 +02:00
Christoph Lendenfeld left a comment
Member

really nice! Good job on making the s_curve function. could potentially be used in ease_fcurve_segment as well

Just some small tweaks

really nice! Good job on making the s_curve function. could potentially be used in `ease_fcurve_segment` as well Just some small tweaks
@ -494,0 +497,4 @@
* or horizontaly. The range of the curve used is from 0 to 1 on "x" and "y" so we can scale it
* (width and height) and move it (xshift and y yshift) to crop the part of the curve we need.
* Slope determins how curvy the shape is */
float curve = height * pow((x - xshift), slope) /

this could be renamed to y or curve_y
after all it's only a single point and not a whole curve

this could be renamed to `y` or `curve_y` after all it's only a single point and not a whole curve
@ -494,0 +529,4 @@
const bool slider_right_side = factor > 0.5;
/* The factor goes from 0 to 1, but for this tool it needs to go from -1 to 1. */
const float long_factor = factor * 2 - 1;

you can also set the slider itself to go from -1/1 using ED_slider_is_bidirectional_set

you can also set the slider itself to go from -1/1 using `ED_slider_is_bidirectional_set`
AresDeveaux added 1 commit 2023-04-14 20:29:46 +02:00
AresDeveaux requested review from Christoph Lendenfeld 2023-04-14 20:30:15 +02:00
Author
First-time contributor

addressed your notes and also another to simplify that came from another slider.

addressed your notes and also another to simplify that came from another slider.
AresDeveaux added 1 commit 2023-04-18 07:06:35 +02:00
AresDeveaux added 1 commit 2023-04-19 10:52:45 +02:00
AresDeveaux added 1 commit 2023-04-19 11:05:56 +02:00
Christoph Lendenfeld approved these changes 2023-04-20 12:29:14 +02:00
Christoph Lendenfeld left a comment
Member

yep looks good to me :)
adding sybren for the final review

yep looks good to me :) adding sybren for the final review
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-04-20 12:29:23 +02:00
AresDeveaux added 1 commit 2023-04-20 21:45:38 +02:00
Christoph Lendenfeld self-assigned this 2023-07-28 10:54:37 +02:00

This feature has been implemented with this PR #110566: Animation: Blend To Ease Slider

This feature has been implemented with this PR [#110566: Animation: Blend To Ease Slider](https://projects.blender.org/blender/blender/pulls/110566)

Pull request closed

Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106519
No description provided.