Animation: Blend To Ease Slider #110566

Merged
Christoph Lendenfeld merged 21 commits from ChrisLend/blender:blend_to_ease_slider into main 2023-08-10 17:51:20 +02:00

The patch has been originally authored by AresDeveaux (#106519: Animation: blend to ease slider)
I am just finishing it up

This PR blends the selected keyframes to an ease-in or ease-out curve.

The patch has been originally authored by AresDeveaux ([#106519: Animation: blend to ease slider](https://projects.blender.org/blender/blender/pulls/106519)) I am just finishing it up This PR blends the selected keyframes to an ease-in or ease-out curve. <video src="/attachments/6f4594ff-29c5-44b3-83ea-4fff7ecc39cd" controls></video>
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-07-28 11:18:52 +02:00
Christoph Lendenfeld added 14 commits 2023-07-28 11:19:00 +02:00
Christoph Lendenfeld requested review from Nate Rupsis 2023-07-28 11:19:36 +02:00
Christoph Lendenfeld added this to the Animation & Rigging project 2023-07-28 11:19:43 +02:00
Christoph Lendenfeld added 1 commit 2023-07-28 15:44:32 +02:00
Nathan Vegdahl requested changes 2023-07-31 14:11:35 +02:00
Nathan Vegdahl left a comment
Member

Code looks good to me (just one small nit).

However, it's not clear to me what the use case is for this...? I'm sure I could think of a contrived case where it would be useful, but I'm struggling to think of any likely situation where this would be what I want. I guess that goes for #110567 as well.

But I could certainly be missing something.

Code looks good to me (just one small nit). However, it's not clear to me what the use case is for this...? I'm sure I could think of a contrived case where it would be useful, but I'm struggling to think of any likely situation where this would be what I want. I guess that goes for #110567 as well. But I could certainly be missing something.
@ -682,0 +719,4 @@
const float height = 2.0;
float xy_shift;
float y_delta;
Member

Might make sense to move the declaration of y_delta inside the for loop below, closer to where it's used.

Might make sense to move the declaration of `y_delta` inside the for loop below, closer to where it's used.
nathanvegdahl marked this conversation as resolved
Member

The consensus in the module meeting was that this is useful. Just the one nit, and then it's ready to land.

The consensus in the module meeting was that this is useful. Just the one nit, and then it's ready to land.
Christoph Lendenfeld added 2 commits 2023-08-10 15:53:01 +02:00
Christoph Lendenfeld requested review from Nathan Vegdahl 2023-08-10 16:04:22 +02:00
Christoph Lendenfeld added 2 commits 2023-08-10 16:34:23 +02:00
Nathan Vegdahl requested changes 2023-08-10 16:46:48 +02:00
Nathan Vegdahl left a comment
Member

Just some very minor nits in a couple comments. Other than that, looks good to me!

Just some very minor nits in a couple comments. Other than that, looks good to me!
@ -707,0 +709,4 @@
/* Formula for 'S' curve we use for the "ease" sliders. The shift values move the curve verticaly
* or horizontaly. The range of the curve used is from 0 to 1 on "x" and "y" so we can scale it
* (width and height) and move it (xshift and y yshift) to crop the part of the curve we need.
* Slope determins how curvy the shape is */
Member

Missing period.

Missing period.
nathanvegdahl marked this conversation as resolved
@ -707,0 +714,4 @@
(pow((x - xshift), slope) + pow((width - (x - xshift)), slope)) +
yshift;
/* The curve has some noise beyond our margins so we clamp the values */
Member

Missing period. I also briefly found the use of the word "noise" here slightly confusing. Not a big deal at all, but maybe change it to something like "The curve doesn't do what we want beyond our margins...".

Missing period. I also briefly found the use of the word "noise" here slightly confusing. Not a big deal at all, but maybe change it to something like "The curve doesn't do what we want beyond our margins...".
nathanvegdahl marked this conversation as resolved
Christoph Lendenfeld added 2 commits 2023-08-10 17:15:35 +02:00
Christoph Lendenfeld requested review from Nathan Vegdahl 2023-08-10 17:15:42 +02:00
Nathan Vegdahl approved these changes 2023-08-10 17:16:58 +02:00
Nathan Vegdahl left a comment
Member

Looks good to me!

Looks good to me!
Christoph Lendenfeld merged commit 8ddb8e0d05 into main 2023-08-10 17:51:20 +02:00
Christoph Lendenfeld deleted branch blend_to_ease_slider 2023-08-10 17:51:22 +02:00
Christoph Lendenfeld removed this from the Animation & Rigging project 2023-11-23 10:56:01 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110566
No description provided.