Animation: Blend Offset Slider #110544

Christoph Lendenfeld · 2023-07-27T17:55:31+02:00

2023-07-27 17:55:31 +02:00

This patch has been authored by Ares Deveaux (#106518: Animation: blend offset slider)
I am just finishing it up.

Adds an operator to the Graph Editor that moves the selected segment up/down so it aligns with the keys before/after the segment.

This patch has been authored by Ares Deveaux ([#106518: Animation: blend offset slider](https://projects.blender.org/blender/blender/pulls/106518)) I am just finishing it up. Adds an operator to the Graph Editor that moves the selected segment up/down so it aligns with the keys before/after the segment. <video src="/attachments/549a5ce9-358e-4b51-93ad-2664793f332b" title="Blend Offset Demo" controls></video>

blend_to_offset_2023_08_10.mp4

789 KiB

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-07-27 17:55:31 +02:00

Christoph Lendenfeld added 17 commits 2023-07-27 17:55:40 +02:00

52a9e65548 added functions

6c90f32d7e took away the "to" in the name

cf7810c00a changed declarations of y_delta

6cdaa21557 Fixed some formating

4fefa0dda6 deleted the split on the vectors

6332c5abae Merge branch 'main' into blend_offset_slider

960b6c41e2 another round of simplification

fab764a6cf deleted 2 likes that I added to test the bidirectional slider

c038ce005f added bidirectional sliders

45de734e6b corrected a small error in the operator

14951f6e71 Merge remote-tracking branch 'origin/main' into blend_offset_slider

5c93d1f2cf Fixes for recent graph slider updates

e5972eb20e Merge branch 'main' into blend_offset_slider

2ef12dd965 resolve merge issues

d5da92021d use apply_fcu_segment_function

6f728931e4 use common draw code for status header

abee345d4e implement sybrens comments

Christoph Lendenfeld requested review from Nate Rupsis 2023-07-27 18:58:58 +02:00

Christoph Lendenfeld changed title from ~~WIP: Animation: Blend Offset Slider~~ to Animation: Blend Offset Slider

2023-07-28 10:42:20 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-07-28 11:20:19 +02:00

Nathan Vegdahl commented

2023-07-31 14:24:35 +02:00

Code looks good to me.

As in #110567 and #110566, I'm not sure what the use case is for this. The closest I can think of is flattening out a section of animation (which definitely comes up, in my experience). But in that case I would want to blend all the keys in the segment to match the y of the key before/after, not just shift them so the first/last key does.

Again, I could totally be missing something here! Just double-checking that the features are motivated by something practical.

Code looks good to me. As in #110567 and #110566, I'm not sure what the use case is for this. The closest I can think of is flattening out a section of animation (which definitely comes up, in my experience). But in that case I would want to blend all the keys in the segment to match the y of the key before/after, not just shift them so the first/last key does. Again, I could totally be missing something here! Just double-checking that the features are motivated by something practical.

Nathan Vegdahl approved these changes 2023-08-10 11:45:49 +02:00

Nathan Vegdahl left a comment

Consensus in the module meeting was to approve! :-)

LGTM

Consensus in the module meeting was to approve! :-) LGTM

Nathan Vegdahl commented

2023-08-10 11:52:44 +02:00

Oh... except it looks like there's conflicts now. Just fix that up and I'll do a quick re-review. But it's otherwise ready to land.

Christoph Lendenfeld added 1 commit 2023-08-10 15:30:23 +02:00

064f18a94a Merge branch 'main' into blend_offset_slider

Christoph Lendenfeld requested review from Nathan Vegdahl 2023-08-10 15:50:50 +02:00

Nathan Vegdahl approved these changes 2023-08-10 16:05:51 +02:00