Martijn Versteegh Baardaap
  • Joined on 2020-06-24
Martijn Versteegh commented on pull request blender/blender#115103 2023-12-27 20:18:00 +01:00
Add a nearest neighbor mode to the MAP UV compositor node.

Now that I think about it, I think maybe we should consider adding bilinear and bicubic as well. Much like the transform node for consistency.

I'd much prefer to do that as a second patch and…

Martijn Versteegh commented on pull request blender/blender-addons#105084 2023-12-24 19:28:16 +01:00
Node Wrangler: Skip internal attributes while populating the 'Shader Editor->Add->Input->Attributes' menu

Needs a better commit message. Will try to formulate one after Xmas.

Martijn Versteegh created pull request blender/blender-addons#105084 2023-12-24 19:26:52 +01:00
Node Wrangler: Skip internal attributes while populating the 'Shader Editor->Add->Input->Attributes' menu
Martijn Versteegh pushed to skiphiddenattrs at Baardaap/blender-addons 2023-12-24 19:25:37 +01:00
c43c42d703 Node Wrangler: Skip internal attributes while populating the 'Shader Editor->Add->Input->Attributes' menu
Martijn Versteegh pushed to skiphiddenattrs at Baardaap/blender-addons 2023-12-24 19:24:28 +01:00
127c4d8be3 Node Wrangler: Skip internal attributes while populating the 'Shadder Editor->Add->Input->Attributes' menu
Martijn Versteegh created branch skiphiddenattrs in Baardaap/blender-addons 2023-12-24 19:24:28 +01:00
Martijn Versteegh created repository Baardaap/blender-addons 2023-12-24 19:08:41 +01:00
Martijn Versteegh commented on pull request blender/blender#115103 2023-12-22 15:20:28 +01:00
Add a nearest neighbor mode to the MAP UV compositor node.

test pass

cb10e7d5e0 Merge branch 'main' into nearest_neighbopur_compositor_uvmap
7a8e349b73 Compositor: Support viewer offset in GPU compositor
45582662a1 EEVEE-Next: Fix Pointshader Requirements
248d7d8340 Fix use of undefined IMATH_INCLUDE_DIRS
3e6139cc30 Anim: RNA, mark armature.collections as editable
Compare 6 commits »
5cdcdcae0e Some renaming of functions/enum values. Comment++
1b9b2a703f Merge branch 'main' into nearest_neighbopur_compositor_uvmap
78c3253553 Fix #116069: Incorrect data transfer custom normals behavior
48b0a504b4 Cleanup: Remove unnecessary argument in mesh normals code
341c54ce21 Fix #116415: Show Empty text for Current Asset Library
Compare 16 commits »
Martijn Versteegh commented on pull request blender/blender#115103 2023-12-22 11:56:42 +01:00
Add a nearest neighbor mode to the MAP UV compositor node.

will do. Ending with a period feels a bit out of place though, as most of the comments surrounding it don't, which is why I didn't either. But the styleguide does say to make full sentences I…

9a80e3d2f2 Cleanup: make format
4f3337722b Use an enum instead of a bool for the node UI
20d9a4106c More clear naming of shader file
Compare 2 commits »
9aa3c8ec33 Create get_shader_name() function and compare custom2 value with enum value instead of 0
74a0344d12 Merge shader infos
154d0c555e Add comment.
3aeade5c35 Merge branch 'main' into nearest_neighbopur_compositor_uvmap
dea7d65ee7 Fix: Crash in single value input to Glare node
Compare 567 commits »
Martijn Versteegh commented on pull request blender/blender#115103 2023-12-19 11:00:38 +01:00
Add a nearest neighbor mode to the MAP UV compositor node.

I can't seem to find this existing enum. Is it maybe something in a branch you have?

I grepped the whole source tree for CMP_NODE_MAP.

But I'll rewrite the somewhat strangely named CMPNodeMapUV…

Martijn Versteegh commented on pull request blender/blender#115103 2023-12-18 16:28:22 +01:00
Add a nearest neighbor mode to the MAP UV compositor node.

I don't really understand what you mean here?

create an enum type and use that instead of bool?

Martijn Versteegh commented on pull request blender/blender#113525 2023-12-18 15:54:08 +01:00
Fix #107500: Custom-data Python validation to prevent crashes

Maybe that's the only place a CustomData layer has been added or deleted before the bpy_mesh.uv_layers['Texture'] layer?

Martijn Versteegh commented on pull request blender/blender#113525 2023-12-18 10:25:46 +01:00
Fix #107500: Custom-data Python validation to prevent crashes

It does not matter (for this specific bug) if you use an existing layer or create a new one.

All that matters is that you should do the

test_vert_color = bpy_mesh.vertex_colors['Test']
`…
Martijn Versteegh commented on pull request blender/blender#113525 2023-12-16 21:31:15 +01:00
Fix #107500: Custom-data Python validation to prevent crashes

To be honest it's a bit questionable if this fix will be included at all I think.

You can work around by always reinitialising any python variables pointing to uv layers (or other attribute…