Bill-Spitzak
  • Joined on 2024-02-16
Bill-Spitzak commented on pull request blender/blender#125149 2024-07-23 00:27:50 +02:00
Fix #124842: Fix CPU compositor sampling errors and make it match GPU

The Extend version of the samplers is used (except for Bilinear which will use Wrap when requested because it was doing it correctly). Clip is done by here so it can be enabled per-axis and it…

Bill-Spitzak commented on pull request blender/blender#125149 2024-07-23 00:25:06 +02:00
Fix #124842: Fix CPU compositor sampling errors and make it match GPU

These are just code cleanup from an aborted attempt to make the same changes to the bicubic sampler. I gave up on that as being too intrusive, in particular because the bicubic one always does…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-23 00:08:05 +02:00
Fix #124133: Transforms shift due to incorrect floor()

This removed a double-invert of the matricies and most likely made the result a lot more accurate.

Sure, but that doesn't belong to this pull request.

I'll look into splitting it if…

Bill-Spitzak commented on issue blender/blender#108944 2024-07-22 23:42:35 +02:00
Compositor: canvas and transforms

I do not think the current GPU implementation needs as many changes as this proposal claims.

The Domain has a transform and a size that define a rectangle (actually a quad) which I believe…

Bill-Spitzak created pull request blender/blender#125149 2024-07-21 01:00:37 +02:00
Fix #124842: Fix CPU compositor sampling errors and make it match GPU
Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-21 00:55:36 +02:00
e5720fd4d4 Fix #124842: Incorrect sampling in CPU compositor
268e2041c2 Fix sampling calls in CPU compositor
f36ed45328 Put the .5 shift into RealizeOnDomainOperation
349cb182fc Compute full transform including corner offsets outside glsl
e63c260e58 Fix #124133: Transforms shift due to incorrect floor()
Compare 101 commits »
Bill-Spitzak commented on pull request blender/blender#124381 2024-07-20 22:41:06 +02:00
Fix #124133: Transforms shift due to incorrect floor()

This removed a double-invert of the matricies and most likely made the result a lot more accurate. But it's primary advantage is that it is a lot easier to figure out what is happening. I had to…

Bill-Spitzak closed pull request blender/blender#124841 2024-07-19 22:49:00 +02:00
WIP: do the 1/2 pixel translation only in RealizeOnDomainOperation
Bill-Spitzak commented on pull request blender/blender#124841 2024-07-19 22:48:58 +02:00
WIP: do the 1/2 pixel translation only in RealizeOnDomainOperation

I have merged this change into the main patch blender/blender#124381 as that results in the minimal change of behavior.

Bill-Spitzak commented on issue blender/blender#124133 2024-07-19 22:46:20 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

Patch has been updated with something that fixes the unexpected blur when odd images are centered in even ones, without altering normal transformations, I have been testing this for some time…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-19 22:37:07 +02:00
Fix #124133: Transforms shift due to incorrect floor()

Patch has been updated. It includes what seems to be a working solution for the "unexpected blur" when an odd-sized domain is realized on an even-sized one. This is a .5 shift, just like before,…

Bill-Spitzak pushed to main at Bill-Spitzak/blender 2024-07-19 22:33:18 +02:00
c0416d4590 Put the .5 shift into RealizeOnDomainOperation
ab3cfde35a Compute full transform including corner offsets outside glsl
51e87db5df Fix #124133: Transforms shift due to incorrect floor()
108b71047a UI: Remove "Widget Label" Text Style
cdf66f5711 Cleanup: Add detail to sculpt boundary methods
Compare 100 commits »
Bill-Spitzak commented on issue blender/blender#124842 2024-07-19 06:18:30 +02:00
CPU compositor Translate sets left and bottom edge to blank pixels

The reported bug is caused by incorrect crops in MemoryBuffer::read(). Fixing or removing these however revealed that interpolation of pixels at the edge is done incorrectly. Nearest and…

Bill-Spitzak commented on pull request blender/blender#124841 2024-07-19 06:03:58 +02:00
WIP: do the 1/2 pixel translation only in RealizeOnDomainOperation

I have been using it like this for a while and it seems to be working well.

Bill-Spitzak closed pull request blender/blender#124760 2024-07-19 00:33:00 +02:00
WIP: halfpixel shift for odd domains
Bill-Spitzak commented on pull request blender/blender#124760 2024-07-19 00:32:58 +02:00
WIP: halfpixel shift for odd domains

I now believe that blender/blender#124841 is a better fix for unexpected blur.

Note that I am convinced any solution must actually do a .5 translation of one…

Bill-Spitzak deleted branch translate from Bill-Spitzak/blender 2024-07-19 00:27:15 +02:00
Bill-Spitzak closed pull request blender/blender#124928 2024-07-19 00:26:31 +02:00
Fix #124842: Prevent rounding errors from introducing black pixels in Translate
Bill-Spitzak commented on pull request blender/blender#124928 2024-07-19 00:26:28 +02:00
Fix #124842: Prevent rounding errors from introducing black pixels in Translate

This does not work for non-integer translations. Cancelling this pull request.