BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

MaterialX Realtime results update in viewport render #10

Merged
Bogdan Nagirniak merged 4 commits from Vasyl-Pidhirskyi/blender-addons:BLEN-412 into materialx-addon 2023-05-18 08:22:01 +02:00
Conversation 0 Commits 4 Files Changed 2 +11
Vasyl Pidhirskyi commented 2023-05-15 14:56:57 +02:00
Collaborator
Copy Link

Purpose

Update after property changes.

Technical steps

Implemented update_prop using self.socket_value_update (from blender docs: "Update after property changes").
Passed update_prop to "update" argument while generating the node's properties.
Made adjustments to generate_node_classes.py.

NOTE

Previously generated nodes should be deleted
c:\Users\ ...\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\materialx_data\materialx_nodes\

### Purpose Update after property changes. ### Technical steps Implemented update_prop using self.socket_value_update (from blender docs: "Update after property changes"). Passed update_prop to "update" argument while generating the node's properties. Made adjustments to generate_node_classes.py. ### NOTE Previously generated nodes should be deleted c:\Users\ ...\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\materialx_data\materialx_nodes\
Vasyl Pidhirskyi self-assigned this 2023-05-15 14:56:57 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-05-15 14:56:57 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-05-15 14:56:57 +02:00
Vasyl Pidhirskyi added 1 commit 2023-05-15 14:56:59 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-05-15 14:57:17 +02:00
Vasyl Pidhirskyi added 1 commit 2023-05-15 15:31:40 +02:00
Bogdan Nagirniak approved these changes 2023-05-16 15:53:10 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works ok

Tested - works ok
Bogdan Nagirniak requested changes 2023-05-16 16:03:04 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

No updates when links are changed

No updates when links are changed
Vasyl Pidhirskyi added 1 commit 2023-05-17 09:56:59 +02:00
Vasyl Pidhirskyi added 1 commit 2023-05-17 10:15:51 +02:00
Bogdan Nagirniak approved these changes 2023-05-18 08:21:30 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works ok

Tested - works ok
Bogdan Nagirniak merged commit 24186fe54c into materialx-addon 2023-05-18 08:22:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Vasyl Pidhirskyi
Georgiy Markelov
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#10
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender-addons:BLEN-412"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?