BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Transmission color doesn't affect the render result #11

Merged
Bogdan Nagirniak merged 1 commits from Vasyl-Pidhirskyi/blender-addons:BLEN-387 into materialx-addon 2023-05-16 20:16:22 +02:00
Conversation 0 Commits 1 Files Changed 1 +4 -8
Vasyl Pidhirskyi commented 2023-05-15 18:11:56 +02:00
Collaborator
Copy Link

Purpose

Transmission color doesn't affect the render result.

Technical steps

Used base_color for specular_color, transmission_color, sheen_color, and coat_color instead of DEFAULT_WHITE_COLOR.
The difference between standard_surface and Principled BSDF is that the latter shares base color between diffuse reflection and refraction components.
Removes redundant code.

### Purpose Transmission color doesn't affect the render result. ### Technical steps Used base_color for specular_color, transmission_color, sheen_color, and coat_color instead of DEFAULT_WHITE_COLOR. The difference between standard_surface and Principled BSDF is that the latter shares `base color` between diffuse reflection and refraction components. Removes redundant code.
Vasyl Pidhirskyi self-assigned this 2023-05-15 18:11:56 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-05-15 18:11:56 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-05-15 18:11:56 +02:00
Vasyl Pidhirskyi added 1 commit 2023-05-15 18:11:58 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-05-15 18:12:28 +02:00
Bogdan Nagirniak approved these changes 2023-05-16 16:04:55 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Not like in Cycles but looks better. Transmission isn't the same for Principled and for Standard Surface

Not like in Cycles but looks better. Transmission isn't the same for Principled and for Standard Surface
Georgiy Markelov approved these changes 2023-05-16 18:31:40 +02:00
Bogdan Nagirniak merged commit 5a9ceb92dc into materialx-addon 2023-05-16 20:16:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Vasyl Pidhirskyi
Georgiy Markelov
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#11
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender-addons:BLEN-387"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?