BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Refactoring of Storm Hydra render addon #13

Merged
Bogdan Nagirniak merged 8 commits from BLEN-413 into storm-hydra-addon 2023-06-01 02:36:50 +02:00
Conversation 0 Commits 8 Files Changed 7 +111 -99
Georgiy Markelov commented 2023-05-23 11:09:18 +02:00
Collaborator
Copy Link

Purpose

Fix review comments and refactoring

Technical steps

  • Added viewport settings
  • added properties to UI
  • various UI improvements
### Purpose Fix review comments and refactoring ### Technical steps * Added viewport settings * added properties to UI * various UI improvements
Georgiy Markelov added 4 commits 2023-05-23 11:09:19 +02:00
Georgiy Markelov self-assigned this 2023-05-23 11:11:01 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-05-23 11:11:02 +02:00
Vasyl Pidhirskyi was assigned by Georgiy Markelov 2023-05-23 11:11:02 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-05-23 11:11:06 +02:00
Georgiy Markelov added 1 commit 2023-05-24 11:11:33 +02:00
Georgiy Markelov added 1 commit 2023-05-24 12:53:35 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-24 14:03:09 +02:00
Bogdan Nagirniak approved these changes 2023-05-24 17:09:45 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Brian Savery (AMD) reviewed 2023-05-24 19:08:35 +02:00
hydra_storm/properties.py Outdated
@ -32,3 +30,3 @@
)
volume_raymarching_step_size: bpy.props.FloatProperty(
name="Volume Raymarching Step Size",
name="Step Size",
Brian Savery (AMD) commented 2023-05-24 19:08:34 +02:00
Collaborator
Copy Link

I prefer the original name "Step size" is too generic.

I prefer the original name "Step size" is too generic.
Georgiy Markelov commented 2023-05-25 09:04:31 +02:00
Author
Collaborator
Copy Link

I renamed it because it better fits UI. Long names are not good.

image

I renamed it because it better fits UI. Long names are not good. ![image](/attachments/ed5b9243-72bd-43d6-b97f-df8361355da3)
Bogdan Nagirniak commented 2023-05-25 11:31:58 +02:00
Owner
Copy Link

Agree, please use original name here. In UI change text as you want:
layout.prop(settings, 'volume_raymarching_step_size', text="Step Size")

Agree, please use original name here. In UI change text as you want: `layout.prop(settings, 'volume_raymarching_step_size', text="Step Size")`
Georgiy Markelov commented 2023-05-25 13:52:21 +02:00
Author
Collaborator
Copy Link

Fixed.

Fixed.
DagerD marked this conversation as resolved
Brian Savery (AMD) reviewed 2023-05-24 19:08:58 +02:00
hydra_storm/properties.py Outdated
@ -37,3 +35,3 @@
)
volume_raymarching_step_size_lighting: bpy.props.FloatProperty(
name="Volume Raymarching Step Size",
name="Step Size Lighting",
Brian Savery (AMD) commented 2023-05-24 19:08:58 +02:00
Collaborator
Copy Link

Same as above.

Same as above.
DagerD marked this conversation as resolved
Bogdan Nagirniak requested changes 2023-05-25 11:33:03 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Change property name as original and use text="..." in UI

Change property name as original and use `text="..."` in UI
Georgiy Markelov added 1 commit 2023-05-25 13:52:11 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-05-25 13:52:32 +02:00
Bogdan Nagirniak approved these changes 2023-05-25 17:44:54 +02:00
Vasyl Pidhirskyi approved these changes 2023-05-30 10:58:36 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Works well.

Works well.
Bogdan Nagirniak reviewed 2023-05-31 17:27:34 +02:00
hydra_storm/properties.py Outdated
@ -25,3 +25,1 @@
class SceneProperties(Properties):
bl_type = bpy.types.Scene
class RenderSettings(bpy.types.PropertyGroup):
Bogdan Nagirniak commented 2023-05-31 17:27:09 +02:00
Owner
Copy Link

Rename to RenderProperties as more related

Rename to `RenderProperties` as more related
BogdanNagirniak marked this conversation as resolved
Brian Savery (AMD) approved these changes 2023-05-31 19:53:43 +02:00
Bogdan Nagirniak added 1 commit 2023-06-01 02:35:55 +02:00
Bogdan Nagirniak merged commit 163daadfdf into storm-hydra-addon 2023-06-01 02:36:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Vasyl Pidhirskyi
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#13
No description provided.
Delete Branch "BLEN-413"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?