BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Refactoring of Storm Hydra render addon #13

Merged
Bogdan Nagirniak merged 8 commits from BLEN-413 into storm-hydra-addon 2023-06-01 02:36:50 +02:00
Conversation 0 Commits 8 Files Changed 7 +6 -6
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9bba3160e5 - Show all commits

4
hydra_storm/properties.py
View File

@ -29,12 +29,12 @@ class RenderSettings(bpy.types.PropertyGroup):
default=False, default=False,
) )
volume_raymarching_step_size: bpy.props.FloatProperty( volume_raymarching_step_size: bpy.props.FloatProperty(
name="Step Size", name="Volume Raymarching Step Size",
DagerD marked this conversation as resolved Outdated
Brian Savery (AMD) commented 2023-05-24 19:08:34 +02:00
Outdated
Review
Copy Link

I prefer the original name "Step size" is too generic.

I prefer the original name "Step size" is too generic.
Georgiy Markelov commented 2023-05-25 09:04:31 +02:00
Outdated
Review
Copy Link

I renamed it because it better fits UI. Long names are not good.

image

I renamed it because it better fits UI. Long names are not good. ![image](/attachments/ed5b9243-72bd-43d6-b97f-df8361355da3)
Bogdan Nagirniak commented 2023-05-25 11:31:58 +02:00
Outdated
Review
Copy Link

Agree, please use original name here. In UI change text as you want:
layout.prop(settings, 'volume_raymarching_step_size', text="Step Size")

Agree, please use original name here. In UI change text as you want: `layout.prop(settings, 'volume_raymarching_step_size', text="Step Size")`
Georgiy Markelov commented 2023-05-25 13:52:21 +02:00
Outdated
Review
Copy Link

Fixed.

Fixed.
description="Step size when raymarching volume", description="Step size when raymarching volume",
default=1.0, default=1.0,
) )
volume_raymarching_step_size_lighting: bpy.props.FloatProperty( volume_raymarching_step_size_lighting: bpy.props.FloatProperty(
name="Step Size Lighting", name="Volume Raymarching Step Size Lighting",
DagerD marked this conversation as resolved Outdated
Brian Savery (AMD) commented 2023-05-24 19:08:58 +02:00
Outdated
Review
Copy Link

Same as above.

Same as above.
description="Step size when raymarching volume for lighting computation", description="Step size when raymarching volume for lighting computation",
default=10.0, default=10.0,
) )

8
hydra_storm/ui.py
View File

@ -58,8 +58,8 @@ class STORM_HYDRA_RENDER_PT_volume_final(FinalPanel):
settings = self.settings(context) settings = self.settings(context)
col = layout.column(align=True) col = layout.column(align=True)
col.prop(settings, "volume_raymarching_step_size") col.prop(settings, "volume_raymarching_step_size", text="Step Size")
col.prop(settings, "volume_raymarching_step_size_lighting") col.prop(settings, "volume_raymarching_step_size_lighting", text="Step Size Lightning")
col.prop(settings, "volume_max_texture_memory_per_field") col.prop(settings, "volume_max_texture_memory_per_field")
@ -102,8 +102,8 @@ class STORM_HYDRA_RENDER_PT_volume_viewport(ViewportPanel):
settings = self.settings(context) settings = self.settings(context)
col = layout.column(align=True) col = layout.column(align=True)
col.prop(settings, "volume_raymarching_step_size") col.prop(settings, "volume_raymarching_step_size", text="Step Size")
col.prop(settings, "volume_raymarching_step_size_lighting") col.prop(settings, "volume_raymarching_step_size_lighting", text="Step Size Lightning")
col.prop(settings, "volume_max_texture_memory_per_field") col.prop(settings, "volume_max_texture_memory_per_field")