BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Implement transparent background for Storm delegate #21

Merged
Bogdan Nagirniak merged 4 commits from Vasyl-Pidhirskyi/blender-addons:BLEN-463 into storm-hydra-addon 2023-07-23 21:01:37 +02:00
Conversation 0 Commits 4 Files Changed 2 +15 -46
3 changed files with 15 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b216fe22c4 - Show all commits

7
hydra_storm/engine.py
View File

@ -33,13 +33,6 @@ class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine):
'maxLights': settings.max_lights,
}
def get_sync_settings(self, engine_type):
settings = bpy.context.scene.hydra_storm.viewport if engine_type == 'VIEWPORT' else \
bpy.context.scene.hydra_storm.final
return {
'enableAlpha': settings.enable_alpha,
}
register, unregister = bpy.utils.register_classes_factory((
StormHydraRenderEngine,

5
hydra_storm/properties.py
View File

@ -48,11 +48,6 @@ class RenderProperties(bpy.types.PropertyGroup):
description="Limit maximum number of lights",
default=16, min=0, max=16,
)
enable_alpha: bpy.props.BoolProperty(
name="Enable Color Alpha",
description="World background is transparent, for compositing the render over another background",
default=False,
)
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Bogdan Nagirniak commented 2023-07-21 23:16:23 +02:00
Outdated
Review
Copy Link

Seems no need for additional properties, just use scene.render.film_transparent

Seems no need for additional properties, just use `scene.render.film_transparent`
class SceneProperties(Properties):

49
hydra_storm/ui.py
View File

@ -58,21 +58,6 @@ class STORM_HYDRA_RENDER_PT_volume_final(bpy.types.Panel):
col.prop(settings, "volume_max_texture_memory_per_field")
class STORM_HYDRA_RENDER_PT_film_final(bpy.types.Panel):
bl_parent_id = STORM_HYDRA_RENDER_PT_final.bl_idname
bl_label = "Film"
bl_space_type = 'PROPERTIES'
bl_region_type = 'WINDOW'
bl_options = {'DEFAULT_CLOSED'}
def draw(self, context):
layout = self.layout
layout.use_property_split = True
layout.use_property_decorate = False
layout.prop(context.scene.hydra_storm.final, "enable_alpha", text="Transparent Background")
#
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Bogdan Nagirniak commented 2023-07-21 23:20:13 +02:00
Outdated
Review
Copy Link

no need separate properties for final or viewport

no need separate properties for final or viewport
# VIEWPORT RENDER SETTINGS
#
@ -111,21 +96,6 @@ class STORM_HYDRA_RENDER_PT_volume_viewport(bpy.types.Panel):
col.prop(settings, "volume_max_texture_memory_per_field")
class STORM_HYDRA_RENDER_PT_film_viewport(bpy.types.Panel):
bl_parent_id = STORM_HYDRA_RENDER_PT_viewport.bl_idname
bl_label = "Film"
bl_space_type = 'PROPERTIES'
bl_region_type = 'WINDOW'
bl_options = {'DEFAULT_CLOSED'}
def draw(self, context):
layout = self.layout
layout.use_property_split = True
layout.use_property_decorate = False
layout.prop(context.scene.hydra_storm.viewport, "enable_alpha", text="Transparent Background")
class STORM_HYDRA_LIGHT_PT_light(Panel):
"""Physical light sources"""
bl_label = "Light"
@ -179,15 +149,26 @@ class STORM_HYDRA_LIGHT_PT_light(Panel):
main_col.prop(light, 'size')
class STORM_HYDRA_RENDER_PT_film(bpy.types.Panel):
bl_label = "Film"
bl_space_type = 'PROPERTIES'
bl_region_type = 'WINDOW'
bl_options = {'DEFAULT_CLOSED'}
def draw(self, context):
layout = self.layout
layout.use_property_split = True
layout.use_property_decorate = False
layout.prop(context.scene.render, "film_transparent", text="Transparent Background")
register_classes, unregister_classes = bpy.utils.register_classes_factory((
STORM_HYDRA_RENDER_PT_final,
STORM_HYDRA_RENDER_PT_volume_final,
STORM_HYDRA_RENDER_PT_film_final,
STORM_HYDRA_RENDER_PT_viewport,
STORM_HYDRA_RENDER_PT_volume_viewport,
STORM_HYDRA_RENDER_PT_film_viewport,
STORM_HYDRA_RENDER_PT_film,
STORM_HYDRA_LIGHT_PT_light,
))