BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Implement transparent background for Storm delegate #21

Merged
Bogdan Nagirniak merged 4 commits from Vasyl-Pidhirskyi/blender-addons:BLEN-463 into storm-hydra-addon 2023-07-23 21:01:37 +02:00
Conversation 0 Commits 4 Files Changed 2 +16 -6
Vasyl Pidhirskyi commented 2023-07-21 16:54:11 +02:00
Collaborator
Copy Link

Purpose

Implement transparent background for Storm delegate
image

Technical steps

Implemented STORM_HYDRA_RENDER_PT_film.

Notes for reviewers

Should be reviewed with the pull request BogdanNagirniak/blender#71

### Purpose Implement transparent background for Storm delegate ![image](/attachments/2e748faf-678a-4c91-b997-f3d8d416142b) ### Technical steps Implemented STORM_HYDRA_RENDER_PT_film. ### Notes for reviewers Should be reviewed with the pull request https://projects.blender.org/BogdanNagirniak/blender/pulls/71
Vasyl Pidhirskyi added 1 commit 2023-07-21 16:54:12 +02:00 
Implemented property enable_alpha.
Implemented STORM_HYDRA_RENDER_PT_film_viewport, STORM_HYDRA_RENDER_PT_film_final.
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-07-21 16:54:24 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-07-21 16:54:24 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:54 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:54 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:54 +02:00
Vasyl Pidhirskyi self-assigned this 2023-07-21 16:54:54 +02:00
Brian Savery (AMD) approved these changes 2023-07-21 19:26:23 +02:00
Bogdan Nagirniak requested changes 2023-07-21 23:20:22 +02:00
hydra_storm/properties.py Outdated
@ -48,6 +48,11 @@ class RenderProperties(bpy.types.PropertyGroup):
description="Limit maximum number of lights",
default=16, min=0, max=16,
)
enable_alpha: bpy.props.BoolProperty(
Bogdan Nagirniak commented 2023-07-21 23:16:23 +02:00
Owner
Copy Link

Seems no need for additional properties, just use scene.render.film_transparent

Seems no need for additional properties, just use `scene.render.film_transparent`
Vasyl-Pidhirskyi marked this conversation as resolved
hydra_storm/ui.py Outdated
@ -58,6 +58,21 @@ class STORM_HYDRA_RENDER_PT_volume_final(bpy.types.Panel):
col.prop(settings, "volume_max_texture_memory_per_field")
class STORM_HYDRA_RENDER_PT_film_final(bpy.types.Panel):
Bogdan Nagirniak commented 2023-07-21 23:20:13 +02:00
Owner
Copy Link

no need separate properties for final or viewport

no need separate properties for final or viewport
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 1 commit 2023-07-23 16:45:17 +02:00 
Utilized film_transparent property to manage background alpha.
Vasyl Pidhirskyi added 1 commit 2023-07-23 16:47:58 +02:00
Vasyl Pidhirskyi added 1 commit 2023-07-23 16:55:37 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-07-23 16:57:26 +02:00
Bogdan Nagirniak approved these changes 2023-07-23 21:01:16 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit aa996bb9a5 into storm-hydra-addon 2023-07-23 21:01:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#21
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender-addons:BLEN-463"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?