BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Implement transparent background for Storm delegate #71

Merged
Bogdan Nagirniak merged 3 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-463 into hydra-render 2023-07-23 21:03:02 +02:00
Conversation 0 Commits 3 Files Changed 4 +13 -7
Vasyl Pidhirskyi commented 2023-07-21 16:50:49 +02:00
Collaborator
Copy Link

Purpose

Implement transparent background for Storm delegate
image

Technical steps

Utilized scene.render.film_transparent build-in blender property for Storm delegate.
Adjusted clear_color to alpha 0.0 for final render.

Notes for reviewers

Should be reviewed with the pull request BogdanNagirniak/blender-addons#21

### Purpose Implement transparent background for Storm delegate ![image](/attachments/2e748faf-678a-4c91-b997-f3d8d416142b) ### Technical steps Utilized scene.render.film_transparent build-in blender property for Storm delegate. Adjusted clear_color to alpha 0.0 for final render. ### Notes for reviewers Should be reviewed with the pull request https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/21
Vasyl Pidhirskyi added 2 commits 2023-07-21 16:51:09 +02:00
84764add0b Moved scene_delegate_settings_ to public as scene_delegate_settings. 
Adjusted get_tasks with condition for sky dome tast and added argument scene_delegate_settings.
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:43 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:43 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-07-21 16:54:44 +02:00
Vasyl Pidhirskyi self-assigned this 2023-07-21 16:54:44 +02:00
Brian Savery (AMD) approved these changes 2023-07-21 19:25:48 +02:00
Bogdan Nagirniak requested changes 2023-07-21 23:26:12 +02:00
source/blender/render/hydra/engine.h Outdated
@ -39,6 +39,7 @@ class Engine {
void set_render_setting(const std::string &key, const pxr::VtValue &val);
std::string render_delegate_name;
SceneDelegateSettings scene_delegate_settings;
Bogdan Nagirniak commented 2023-07-21 23:11:44 +02:00
Owner
Copy Link

That's not a good idea to change structure of engine just for using skydome task from light_tasks_delegate_.

That's not a good idea to change structure of engine just for using skydome task from `light_tasks_delegate_`.
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/final_engine.cc Outdated
@ -110,3 +110,3 @@
light_tasks_delegate_->set_camera_and_viewport(
free_camera_delegate_->GetCameraId(), pxr::GfVec4d(0, 0, resolution_[0], resolution_[1]));
tasks_ = light_tasks_delegate_->get_tasks();
tasks_ = light_tasks_delegate_->get_tasks(scene_delegate_settings);
Bogdan Nagirniak commented 2023-07-21 23:26:08 +02:00
Owner
Copy Link

Find corresponded c++ setting for scene.render.film_transparent

Find corresponded c++ setting for `scene.render.film_transparent`
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/light_tasks_delegate.cc Outdated
@ -19,3 +20,3 @@
}
pxr::HdTaskSharedPtrVector LightTasksDelegate::get_tasks()
pxr::HdTaskSharedPtrVector LightTasksDelegate::get_tasks(const SceneDelegateSettings &settings)
Bogdan Nagirniak commented 2023-07-21 23:24:31 +02:00
Owner
Copy Link

simplify by using something like bool transparent_background

simplify by using something like `bool transparent_background`
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 1 commit 2023-07-23 16:38:09 +02:00
c2a8dc5209 Revert changes. 
Utilized scene.render.film_transparent build-in blender property for Storm delegate.
Adjusted clear_color to alpha 0.0 for final render.
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-07-23 17:00:34 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-07-23 17:00:40 +02:00
Bogdan Nagirniak approved these changes 2023-07-23 21:02:02 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit 3517223676 into hydra-render 2023-07-23 21:03:02 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#71
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender_bn:BLEN-463"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?