BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

WIP Make shadows visible for Storm delegate #26

Closed
Vasyl Pidhirskyi wants to merge 2 commits from BLEND-469 into storm-hydra-addon
pull from: BLEND-469
merge into: BogdanNagirniak:storm-hydra-addon

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 2 Files Changed 1 +78 -27
Vasyl Pidhirskyi commented 2023-07-28 15:31:08 +02:00
Collaborator
Copy Link

Purpose

Add support for shadows for Storm delegate.

image

Technical steps

Implemented UI panel STORM_HYDRA_RENDER_PT_light_shadows.
Implemented UI panel STORM_HYDRA_RENDER_PT_shadows.
Reuse Eevee properties use_shadow, shadow_buffer_bias, shadow_cascade_max_distance, shadow_cascade_fade, shadow_cascade_size to be able to set up shadows.

Notes for reviewers

At this point only Sun Light supports shadow.
Should be verified with BogdanNagirniak/blender#80

### Purpose Add support for shadows for Storm delegate. ![image](/attachments/f3220c2b-9342-426a-ac59-8be958210334) ### Technical steps Implemented UI panel `STORM_HYDRA_RENDER_PT_light_shadows`. Implemented UI panel `STORM_HYDRA_RENDER_PT_shadows`. Reuse Eevee properties `use_shadow`, `shadow_buffer_bias`, `shadow_cascade_max_distance`, `shadow_cascade_fade`, `shadow_cascade_size` to be able to set up shadows. ### Notes for reviewers At this point only Sun Light supports shadow. Should be verified with https://projects.blender.org/BogdanNagirniak/blender/pulls/80
image.png
145 KiB
Vasyl Pidhirskyi added 1 commit 2023-07-28 15:31:10 +02:00 
Implemented UI panel STORM_HYDRA_RENDER_PT_light_shadows
Reuse Eevee properties "shadow_buffer_bias", "shadow_cascade_max_distance", "shadow_cascade_fade", "shadow_cascade_size" to be able to set up shadows.
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-07-28 15:32:23 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-07-28 15:32:23 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-07-28 15:32:23 +02:00
Vasyl Pidhirskyi self-assigned this 2023-07-28 15:32:24 +02:00
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-07-28 15:32:29 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-07-28 15:32:34 +02:00
Vasyl Pidhirskyi added 1 commit 2023-07-31 22:35:36 +02:00
Vasyl Pidhirskyi changed title from WIP Make shadows visible for Storm delegate to Make shadows visible for Storm delegate 2023-08-02 16:02:57 +02:00
Bogdan Nagirniak changed title from Make shadows visible for Storm delegate to WIP Make shadows visible for Storm delegate 2023-08-03 16:24:26 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#26
No description provided.
Delete Branch "BLEND-469"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?