forked from blender/blender
Make object visibility and instancing creation to be calculated via depsgraph #57
No reviewers
Labels
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: BogdanNagirniak/blender#57
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "BLEN-442"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Purpose
Fix code review comments:
blender/blender#104712 (comment)
blender/blender#104712 (comment)
blender/blender#104712 (comment)
Technical steps
InstancerData
inBlenderSceneDelegate
for whole scene.Note
After this PR some code cleanup would be required + do some optimization in instancing creation. This would be done in separate PR.
Why not do the instancing optimization here as well?
These checkboxes don't work properly
Works fine.
Made instancing optimization here as well.
discussed offline about updates issue + comments in code
@ -529,3 +439,3 @@
DEGObjectIterSettings settings = {0};
settings.depsgraph = depsgraph;
settings.flags = DEG_ITER_OBJECT_FLAG_LINKED_DIRECTLY | DEG_ITER_OBJECT_FLAG_LINKED_VIA_SET;
settings.flags = DEG_ITER_OBJECT_FLAG_LINKED_DIRECTLY | DEG_ITER_OBJECT_FLAG_LINKED_VIA_SET |
use macro
DEG_OBJECT_ITER_FOR_RENDER_ENGINE_FLAGS
here@ -48,3 +43,3 @@
void update_as_parent();
void update_double_sided(MaterialData *mat_data);
void pre_update();
Please add comment why this is done in this way
works fine