BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Fix wrong path for PXR_MTLX_STDLIB_SEARCH_PATHS #30

Merged
Bogdan Nagirniak merged 3 commits from BLEN-398 into hydra-render 2023-04-28 11:44:03 +02:00
Conversation 0 Commits 3 Files Changed 1 +3 -4
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c3ad228d80 - Show all commits

7
scripts/modules/bpy_hydra.py
View File

@ -66,10 +66,9 @@ class HydraRenderEngine(bpy.types.RenderEngine):
def register(cls): def register(cls):
_bpy_hydra.init() _bpy_hydra.init()
root_folder = "blender.shared" if platform.system() == 'Windows' else "lib" root_folder = "blender.shared" if platform.system() == 'Windows' else "lib"
os.environ['PXR_MTLX_STDLIB_SEARCH_PATHS'] = os.pathsep.join([Path(bpy.app.binary_path).parent / os.environ['PXR_MTLX_STDLIB_SEARCH_PATHS'] = os.pathsep.join([
BrianSavery marked this conversation as resolved Outdated
Brian Savery (AMD) commented 2023-04-27 00:45:22 +02:00
Outdated
Review
Copy Link

Isn't there a more compact way to do this in python? Seems you're going back and forth from string to path and using path separators? If it's a path you shouldn't have to use os.pathseparator.

Isn't there a more compact way to do this in python? Seems you're going back and forth from string to path and using path separators? If it's a path you shouldn't have to use os.pathseparator.
Bogdan Nagirniak commented 2023-04-27 09:12:18 +02:00
Outdated
Review
Copy Link

os.pathsep equals to ';' in windows or ':' in unix to separate different paths in env variable

`os.pathsep` equals to ';' in windows or ':' in unix to separate different paths in env variable
Brian Savery (AMD) commented 2023-04-27 23:05:35 +02:00
Outdated
Review
Copy Link

I understand that but doing some_path / some_other_path takes care of worrying about the pathsep

I understand that but doing `some_path / some_other_path` takes care of worrying about the pathsep
f"{root_folder}/materialx/libraries", Path(bpy.app.binary_path).parent / f"{root_folder}/materialx/libraries",
os.environ.get('PXR_MTLX_STDLIB_SEARCH_PATHS', "") os.environ.get('PXR_MTLX_STDLIB_SEARCH_PATHS', "")])
])
@classmethod @classmethod
def unregister(cls): def unregister(cls):