Cedric Steiert Bujus_Krachus
  • Germany
  • Game Engineering Student, modeller, coder and gamer :D

  • Joined on 2021-01-09
Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

curoff += 3

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

Usually todos follow this pattern: TODO: i want to be awesome!

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

better move the nl after the validation section

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

could get indented further, as pose_bone is None if ``skeleton` is None

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

like above with or

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code & print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

like above could get simplified using or

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

this check could be saved if the code gets moved into the else of line 3338, where the check if not joint_name: happens

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

simplify to f = f.lstrip('"'), the extra operation of checking first is not needed nor recommended

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:23 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code & print needed above?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

Ideally be a tad more concise, maybe something along the lines like TIME_MULTIPLIER

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

which errors are expected? Currently it's a wildcard, thus ideally provide the exception type