Cedric Steiert Bujus_Krachus
  • Germany
  • Game Engineering Student, modeller, coder and gamer :D

  • Joined on 2021-01-09
Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

which errors are expected? Currently it's a wildcard, thus ideally provide the exception type

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

second check of skeleton is not needed, as it's above already

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

wi?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

Ideally be a tad more concise, maybe something along the lines like TIME_MULTIPLIER

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

snake_case: skin_coord

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

like above could get simplified using or

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

i assume this triggers if first_joint_name is None, then simplify to first_joint_name = child.getDefName() or child.getFieldAsString('name', None, ancestry)

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

is unpacking needed or just the conversion to tuple?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

print needed?

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code, either remove the commented out code pieces or explain why it's currently not used

Cedric Steiert commented on pull request extensions/io_scene_x3d#23 2024-10-18 21:29:22 +02:00
WIP: X3D HAnim with Blender bones and animation

dead code