Charles Wardlaw CharlesWardlaw
0 Followers · 0 Following
  • Joined on 2004-11-19
Repositories
1
 Projects Public Activity Starred Repositories
Charles Wardlaw created branch bugfix/apple_cwd_tests in CharlesWardlaw/blender 2023-02-21 01:32:10 +01:00
Charles Wardlaw pushed to bugfix/apple_cwd_tests at CharlesWardlaw/blender 2023-02-21 01:32:10 +01:00
b45a3189ed Fixed tests for MacOS storage_apple.mm functions.
7c1e26dd64 Merge branch 'blender-v3.5-release'
5a86193b1c Fix #82936: Make Geometry Nodes modifier icon blue in outliner
cc925b9282 Nodes: Allow adding multiple search items per type in add menu
ceba1854f9 BLI: add function for changing working directory
Compare 10 commits »
Charles Wardlaw created pull request SonnyCampbell_Unity/blender#1 2023-02-15 00:09:02 +01:00
Removed _apple_ functions and replaced with #if guards for CWD utility helpers
Charles Wardlaw pushed to change-working-directory at CharlesWardlaw/blender 2023-02-15 00:05:43 +01:00
6477a8f6c8 Removed _apple_ functions and replaced with #if guards for CWD utility helpers
74de514dcc Add messaging to test cases. Use std::tmpnam for creating a temporary file.
96aa7ab367 T99807: Separate logic for changing working directory.
Compare 3 commits »
Charles Wardlaw created branch change-working-directory in CharlesWardlaw/blender 2023-02-15 00:05:43 +01:00
Charles Wardlaw commented on pull request blender/blender#104525 2023-02-13 22:16:19 +01:00
BLI: add function for changing working directory

Are you saying you'd like us to put an #if !defined(__APPLE__) around BLI_current_working_dir in storage.c?

The function in storage.c has code for windows and code for linux, which is not…

Charles Wardlaw pushed to D16344-usd-shapes-export at CharlesWardlaw/blender 2023-02-13 19:43:47 +01:00
302565279a Changed read_mesh as per Hans' request.
Charles Wardlaw pushed to D16344-usd-shapes-export at CharlesWardlaw/blender 2023-02-13 19:32:53 +01:00
807f908923 Moved edge calculation inside the loop.
Charles Wardlaw pushed to D16344-usd-shapes-export at CharlesWardlaw/blender 2023-02-13 19:27:52 +01:00
bf96c97b8f Small change to mesh_from_prim for clarity.
Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 19:11:10 +01:00
USD Import: USD Shapes Support

No, because active_mesh was created by mesh_from_prim() which does not calculate the edges. They need to be calculated either way.

Charles Wardlaw pushed to D16344-usd-shapes-export at CharlesWardlaw/blender 2023-02-13 19:09:30 +01:00
749bfec01e Addressing comments.
Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:59:18 +01:00
USD Import: USD Shapes Support

Is there any particular reason this is optional? Seems like it would be nice to avoid adding the option unless it's actually helpful (maybe it is!)

Some folks aren't going to want Shapes…

Charles Wardlaw pushed to D16344-usd-shapes-export at CharlesWardlaw/blender 2023-02-13 18:52:03 +01:00
52cdae0f36 Addressing latest comments. Rolled back subrepos.
Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:49:09 +01:00
USD Import: USD Shapes Support

Seems to be fine now without-- removed.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:48:48 +01:00
USD Import: USD Shapes Support

Reformatted file.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:48:31 +01:00
USD Import: USD Shapes Support

Changed.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:48:27 +01:00
USD Import: USD Shapes Support

Removed.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:48:26 +01:00
USD Import: USD Shapes Support

Removed.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:43:35 +01:00
USD Import: USD Shapes Support

Added.

Charles Wardlaw commented on pull request blender/blender#104707 2023-02-13 18:43:27 +01:00
USD Import: USD Shapes Support

Removed.