Christophe Hery Christophe-Hery
  • Joined on 2021-07-19
Christophe Hery commented on pull request blender/blender#110989 2023-08-16 23:02:11 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

I am perhaps discovering a bug in the proposed re-implementation. It is not obvious on first read, but there are actually and unfortunately two variables exactly called pdf in the current code…

Christophe Hery commented on pull request blender/blender#110989 2023-08-15 20:26:07 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

Here, it's quite clear how the non-fixed radius mapping preserves the overall look of the diffuse baseline much better.

Thanks for doing this test. It showes the advantage of the "non-fixed…

Christophe Hery commented on pull request blender/blender#110989 2023-08-11 16:58:53 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

In the end, I don't have a particularly strong opinion here. The 50/50 mix feels weird, but I can't argue with results 😄

Great tests. But for the case of skin, I would strongly suggest you…

Christophe Hery commented on pull request blender/blender#110989 2023-08-11 16:50:14 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

One idea: We already have two different subsurface modes for the albedo parametrization. The adaptive-radius mode works well for fairly dense materials like skin, but can cause issues for…

Christophe Hery commented on pull request blender/blender#110989 2023-08-11 02:41:33 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

Also, the Subsurface IOR input is removed - conceptually, the subsurface component is below the interface which generates the dielectric specular reflection, so it should share the same…

Christophe Hery commented on pull request blender/blender#110989 2023-08-11 02:38:03 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

I'm not convinced yet that we need a dedicated Subsurface Color, and it's not clear it will be in the final version of OpenPBR. Maybe we could leave it out, and then if we are sure we need it…

Christophe Hery commented on pull request blender/blender#110989 2023-08-11 02:29:41 +02:00
Cycles: Tweak Principled BSDF Subsurface parameters

From a theoretical perspective, I'm not super happy with this mix and the hardcoded roughness, and would like to see if we can find a way to just use refraction using the main surface roughness…

Christophe Hery commented on issue blender/blender#92212 2023-04-18 16:55:58 +02:00
Cycles Metal device

Seems like I cannot repro anymore this week (from a synced up main).

With the same scene/settings, including hairs as Shape = 3D Curves under MetalRT (experimental - full), on a build from two…

Christophe Hery commented on issue blender/blender#92212 2023-04-18 16:51:20 +02:00
Cycles Metal device

Seems like I cannot repro anymore this week (from a synced up main).

With the same scene/settings, including hairs as Shape = 3D Curves under MetalRT (experimental - full), on a build from two…