DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

Implement type conversion for NodeItem #10

Closed
Bogdan Nagirniak wants to merge 9 commits from BogdanNagirniak/blender:matx-nodeitem-type into matx-export-material
pull from: BogdanNagirniak/blender:matx-nodeitem-type
merge into: DagerD:matx-export-material

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 9 Files Changed 8 +610 -459
Bogdan Nagirniak commented 2023-09-05 01:07:24 +02:00
Collaborator
Copy Link

Purpose

NodeItem requires convert() method for node type conversion. This will simplify arithmetic and other methods.

Technical steps

  1. Moved NodeItem type and conditional type in if_else from string to enum values.
  2. Implemented NodeItem::convert() method.
  3. Simplified set_input methods.
  4. Refactor: rearranged functions in NodeItem to satisfy blender code style.
### Purpose `NodeItem` requires `convert()` method for node type conversion. This will simplify arithmetic and other methods. ### Technical steps 1. Moved `NodeItem` type` and conditional type` in `if_else` from `string` to `enum` values. 2. Implemented `NodeItem::convert()` method. 3. Simplified `set_input` methods. 4. Refactor: rearranged functions in `NodeItem` to satisfy blender code style.
Bogdan Nagirniak added 9 commits 2023-09-05 01:07:42 +02:00 
Removed unused code, Simplified some functions.
Bogdan Nagirniak commented 2023-09-05 01:09:04 +02:00
Author
Collaborator
Copy Link

Mistakenly recreated one more PR

Mistakenly recreated one more PR
Bogdan Nagirniak closed this pull request 2023-09-05 01:09:47 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#10
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-nodeitem-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?