DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

Parsing Improvements #14

Merged
Bogdan Nagirniak merged 5 commits from matx-parsing-improvements into matx-export-material 2023-09-07 15:10:17 +02:00
Conversation 0 Commits 5 Files Changed 21 +115 -103
Georgiy Markelov commented 2023-09-07 13:33:25 +02:00
Owner
Copy Link

Purpose

Perform parsing Improvements

Technical steps

  • Added NodeItem::create_node()
  • Added NodeItem::set_input_output()
  • Removed NodeItem::set_input() with out_name parameter
  • NodeParser::create_node(): changed type to NodeItem::Type
  • Logging improvements
  • NodeParser::value() -> NodeParser::val()
  • Renamings and code improvements
### Purpose Perform parsing Improvements ### Technical steps * Added `NodeItem::create_node()` * Added `NodeItem::set_input_output()` * Removed `NodeItem::set_input()` with `out_name` parameter * `NodeParser::create_node()`: changed type to `NodeItem::Type` * Logging improvements * `NodeParser::value()` -> `NodeParser::val()` * Renamings and code improvements
Georgiy Markelov added 3 commits 2023-09-07 13:33:42 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-09-07 13:34:16 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-09-07 13:34:17 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-09-07 13:34:17 +02:00
Georgiy Markelov added 1 commit 2023-09-07 14:36:12 +02:00
Georgiy Markelov added 1 commit 2023-09-07 14:56:00 +02:00
Bogdan Nagirniak approved these changes 2023-09-07 15:09:41 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit a610ec2ba3 into matx-export-material 2023-09-07 15:10:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#14
No description provided.
Delete Branch "matx-parsing-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?