DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

MaterialX: add color nodes #17

Merged
Bogdan Nagirniak merged 10 commits from matx-add-color-nodes into matx-export-material 2023-09-11 18:57:06 +02:00
Conversation 0 Commits 10 Files Changed 9 +130
Georgiy Markelov commented 2023-09-11 16:38:43 +02:00
Owner
Copy Link

Purpose

Add support for Color nodes

Technical steps

Added:

  • Gamma

Partially implemented:

  • Light Falloff
  • Light Path

Not implemented:

  • Color Ramp
  • Curves Float
  • Curves RGB
  • Wavelength
### Purpose Add support for Color nodes ### Technical steps Added: * Gamma Partially implemented: * Light Falloff * Light Path Not implemented: * Color Ramp * Curves Float * Curves RGB * Wavelength
Georgiy Markelov added 9 commits 2023-09-11 16:39:06 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-09-11 16:39:16 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-09-11 16:39:16 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-09-11 16:39:17 +02:00
Bogdan Nagirniak requested changes 2023-09-11 16:52:37 +02:00
source/blender/nodes/shader/materialx/nodes/gamma.cc Outdated
@ -0,0 +8,4 @@
NodeItem GammaNodeParser::compute()
{
NodeItem color = get_input_value("Color", NodeItem::Type::Color3);
Bogdan Nagirniak commented 2023-09-11 16:41:17 +02:00
Collaborator
Copy Link

Color4 ?

Color4 ?
source/blender/nodes/shader/materialx/nodes/gamma.cc
@ -0,0 +13,4 @@
NodeItem res = create_node("power", NodeItem::Type::Color3);
res.set_input("in1", color);
res.set_input("in2", gamma);
Bogdan Nagirniak commented 2023-09-11 16:41:39 +02:00
Collaborator
Copy Link

color ^ gamma

color ^ gamma
Georgiy Markelov added 1 commit 2023-09-11 17:36:26 +02:00
Bogdan Nagirniak approved these changes 2023-09-11 18:56:19 +02:00
Bogdan Nagirniak merged commit 14ab54453f into matx-export-material 2023-09-11 18:57:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#17
No description provided.
Delete Branch "matx-add-color-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?