DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

Support group nodes #22

Merged
Bogdan Nagirniak merged 18 commits from BogdanNagirniak/blender:matx-group-nodes into matx-export-material 2023-09-18 12:49:19 +02:00
Conversation 0 Commits 18 Files Changed 13 +345 -50
Bogdan Nagirniak commented 2023-09-14 19:12:13 +02:00
Collaborator
Copy Link

Purpose

Group nodes should be supported.

Technical steps

  1. Created classes GroupNodeParser, GroupOutputNodeParser, GroupInputNodeParser in materialx/group_nodes.cc/.h.
  2. Added support of NodeItem::input, NodeItem::output.
  3. Added control to use <nodegraph> by #define USE_MATERIALX_NODEGRAPH. Disabled by default because pxr::UsdMtlxRead() doesn't perform nodegraphs.
  4. Added logging of stage->ExportToString() after pxr::UsdMtlxRead().
  5. Improvement in node_shader_tex_noise.cc.
### Purpose Group nodes should be supported. ### Technical steps 1. Created classes `GroupNodeParser`, `GroupOutputNodeParser`, `GroupInputNodeParser` in `materialx/group_nodes.cc/.h`. 2. Added support of `NodeItem::input`, `NodeItem::output`. 3. Added control to use `<nodegraph>` by `#define USE_MATERIALX_NODEGRAPH`. Disabled by default because `pxr::UsdMtlxRead()` doesn't perform nodegraphs. 4. Added logging of `stage->ExportToString()` after `pxr::UsdMtlxRead()`. 5. Improvement in `node_shader_tex_noise.cc`.
Bogdan Nagirniak added 12 commits 2023-09-14 19:12:35 +02:00 
Made group nodes to work with output
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-09-14 19:12:43 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-09-14 19:12:44 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-09-14 19:12:57 +02:00
Bogdan Nagirniak self-assigned this 2023-09-14 19:12:57 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-09-14 19:12:57 +02:00
Bogdan Nagirniak added 1 commit 2023-09-15 10:10:13 +02:00
Bogdan Nagirniak added 1 commit 2023-09-15 10:52:52 +02:00
Bogdan Nagirniak added 2 commits 2023-09-15 20:26:15 +02:00
Bogdan Nagirniak added 1 commit 2023-09-15 20:27:43 +02:00
Georgiy Markelov reviewed 2023-09-18 10:36:06 +02:00
source/blender/nodes/shader/materialx/node_item.cc Outdated
@ -781,0 +817,4 @@
if (ELEM(type, Type::Color3, Type::Color4) &&
ELEM(category, "sin", "cos", "tan", "asin", "acos", "atan2", "sqrt", "ln", "exp"))
{
/* Such fucntions doesn't have implementation in MaterialX, converting to Vector types */
Georgiy Markelov commented 2023-09-18 10:16:37 +02:00
Owner
Copy Link

typo fucntions and plural form

typo `fucntions` and plural form
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak added 1 commit 2023-09-18 12:36:24 +02:00
Georgiy Markelov approved these changes 2023-09-18 12:38:15 +02:00
Bogdan Nagirniak merged commit 412b40266f into matx-export-material 2023-09-18 12:49:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#22
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-group-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?