DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

MaterialX: Implement more shader nodes #23

Merged
Bogdan Nagirniak merged 4 commits from matx-add-other-shader-nodes into matx-export-material 2023-09-15 20:11:01 +02:00
Conversation 0 Commits 4 Files Changed 5 +115 -1
Georgiy Markelov commented 2023-09-15 14:47:16 +02:00
Owner
Copy Link

Purpose

Implement more shader nodes

Technical steps

Added type: NodeItem::Type::multioutput
Added nodes:

  • Glossy BSDF
  • Glass BSDF
  • Refraction BSDF
### Purpose Implement more shader nodes ### Technical steps Added type: `NodeItem::Type::multioutput` Added nodes: * Glossy BSDF * Glass BSDF * Refraction BSDF
Georgiy Markelov added 4 commits 2023-09-15 14:47:33 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-09-15 14:47:39 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-09-15 14:47:40 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-09-15 14:47:40 +02:00
Bogdan Nagirniak approved these changes 2023-09-15 18:17:50 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Looks good

Looks good
Vasyl Pidhirskyi reviewed 2023-09-15 19:42:29 +02:00
source/blender/nodes/shader/nodes/node_shader_bsdf_glass.cc
@ -45,0 +77,4 @@
conductor.set_input_output("extinction", artistic_ior, "extinction");
conductor.set_input("roughness", roughness);
NodeItem res = create_node("mix", NodeItem::Type::BSDF);
Vasyl Pidhirskyi commented 2023-09-15 19:40:15 +02:00
Collaborator
Copy Link

Dielectric already has Reflection and Transmission channels (dielectric -> scatter_mode = "RT"). Do we need one more mix with the Reflection channel (conductor)?

Dielectric already has Reflection and Transmission channels (dielectric -> scatter_mode = "RT"). Do we need one more mix with the Reflection channel (conductor)?
Bogdan Nagirniak approved these changes 2023-09-15 20:10:27 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit f6e00155f9 into matx-export-material 2023-09-15 20:11:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#23
No description provided.
Delete Branch "matx-add-other-shader-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?