DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

Fix creating 2 <image> nodes in TexImage when Color and Output are connected #24

Merged
Bogdan Nagirniak merged 1 commits from BogdanNagirniak/blender:matx-fix-teximage-nodes into matx-export-material 2023-09-19 18:12:58 +02:00
Conversation 0 Commits 1 Files Changed 3 +112 -58
Bogdan Nagirniak commented 2023-09-18 14:36:29 +02:00
Collaborator
Copy Link

Purpose

TexImage node creates 2 nodes when Color and Output are connected.

Technical steps

Added name to node, same as node_name with Color output.
Added implementation of TexEnvironment node.
Fixed naming in group_nodes.cc

### Purpose TexImage node creates 2 <image> nodes when Color and Output are connected. ### Technical steps Added name to <image> node, same as node_name with Color output. Added implementation of TexEnvironment node. Fixed naming in group_nodes.cc
Bogdan Nagirniak added 1 commit 2023-09-18 14:36:49 +02:00 
Added implementation of TexEnvironment node.
Fixed naming in group_nodes.cc
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-09-18 14:37:00 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-09-18 14:37:01 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-09-18 14:37:08 +02:00
Bogdan Nagirniak self-assigned this 2023-09-18 14:37:09 +02:00
Brian Savery (AMD) approved these changes 2023-09-19 01:33:35 +02:00
Georgiy Markelov approved these changes 2023-09-19 17:30:02 +02:00
Georgiy Markelov left a comment
Owner
Copy Link

Works fine.

Works fine.
Bogdan Nagirniak merged commit 1bafc3518a into matx-export-material 2023-09-19 18:12:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#24
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-fix-teximage-nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?