DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

MaterialX: add support for Vector nodes #27

Merged
Bogdan Nagirniak merged 13 commits from Vasyl-Pidhirskyi/blender:BLEN-525 into matx-export-material 2023-09-22 10:03:45 +02:00
Conversation 0 Commits 13 Files Changed 10 +267 -1
Vasyl Pidhirskyi commented 2023-09-19 23:24:47 +02:00
Collaborator
Copy Link

Purpose

Add support for Vector nodes.

Technical steps

Fixed normal map color input type to Vector3.
Implemented NodeItem method rotate3d.
Implemented nodes

Added:

  • Bump
  • Mapping
  • Normal
  • Vector Rotate
  • Vector Transform

Partially implemented (only node implementation):

  • Vector Displacement
  • Displacement

Not implemented:

  • Vector Curves
### Purpose Add support for Vector nodes. ### Technical steps Fixed normal map color input type to Vector3. Implemented NodeItem method rotate3d. Implemented nodes Added: * Bump * Mapping * Normal * Vector Rotate * Vector Transform Partially implemented (only node implementation): * Vector Displacement * Displacement Not implemented: * Vector Curves
Vasyl Pidhirskyi added 8 commits 2023-09-19 23:24:56 +02:00
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-09-19 23:25:33 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-09-19 23:25:33 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:40 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:41 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:41 +02:00
Vasyl Pidhirskyi self-assigned this 2023-09-19 23:25:41 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-20 08:45:40 +02:00
Georgiy Markelov requested changes 2023-09-20 16:10:35 +02:00
Georgiy Markelov left a comment
Owner
Copy Link

Please merge with matx-export-material and get rid of set_input

Please merge with `matx-export-material` and get rid of `set_input`
👍 1
source/blender/nodes/shader/nodes/node_shader_vector_transform.cc
@ -140,0 +147,4 @@
std::string fromspace = "world";
std::string tospace = "world";
NodeItem vector = get_input_value("Vector", NodeItem::Type::Vector3);
switch (nodeprop->convert_from) {
Georgiy Markelov commented 2023-09-20 16:10:08 +02:00
Owner
Copy Link

Here and other places:

default:
	BLI_assert_unreachable();
Here and other places: ``` default: BLI_assert_unreachable(); ```
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 1 commit 2023-09-20 17:49:20 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-09-20 17:53:50 +02:00
Brian Savery (AMD) approved these changes 2023-09-20 23:00:06 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-21 19:20:40 +02:00
f9f73e7459 Refactored, code improvements. 
Fixed normal map type.
Vasyl Pidhirskyi added 1 commit 2023-09-21 19:27:46 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-22 10:00:11 +02:00
Bogdan Nagirniak approved these changes 2023-09-22 10:02:44 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Looks good

Looks good
Bogdan Nagirniak merged commit 74afa9c393 into matx-export-material 2023-09-22 10:03:44 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#27
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender:BLEN-525"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?