MaterialX: add support for Vector nodes #27

Merged
Bogdan Nagirniak merged 13 commits from Vasyl-Pidhirskyi/blender:BLEN-525 into matx-export-material 2023-09-22 10:03:45 +02:00
Collaborator

Purpose

Add support for Vector nodes.

Technical steps

Fixed normal map color input type to Vector3.
Implemented NodeItem method rotate3d.
Implemented nodes

Added:

  • Bump
  • Mapping
  • Normal
  • Vector Rotate
  • Vector Transform

Partially implemented (only node implementation):

  • Vector Displacement
  • Displacement

Not implemented:

  • Vector Curves
### Purpose Add support for Vector nodes. ### Technical steps Fixed normal map color input type to Vector3. Implemented NodeItem method rotate3d. Implemented nodes Added: * Bump * Mapping * Normal * Vector Rotate * Vector Transform Partially implemented (only node implementation): * Vector Displacement * Displacement Not implemented: * Vector Curves
Vasyl Pidhirskyi added 8 commits 2023-09-19 23:24:56 +02:00
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-09-19 23:25:33 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-09-19 23:25:33 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:40 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:41 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-09-19 23:25:41 +02:00
Vasyl Pidhirskyi self-assigned this 2023-09-19 23:25:41 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-20 08:45:40 +02:00
Georgiy Markelov requested changes 2023-09-20 16:10:35 +02:00
Georgiy Markelov left a comment
Owner

Please merge with matx-export-material and get rid of set_input

Please merge with `matx-export-material` and get rid of `set_input`
@ -140,0 +147,4 @@
std::string fromspace = "world";
std::string tospace = "world";
NodeItem vector = get_input_value("Vector", NodeItem::Type::Vector3);
switch (nodeprop->convert_from) {

Here and other places:

default:
	BLI_assert_unreachable();
Here and other places: ``` default: BLI_assert_unreachable(); ```
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 1 commit 2023-09-20 17:49:20 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-09-20 17:53:50 +02:00
Brian Savery (AMD) approved these changes 2023-09-20 23:00:06 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-21 19:20:40 +02:00
Fixed normal map type.
Vasyl Pidhirskyi added 1 commit 2023-09-21 19:27:46 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-22 10:00:11 +02:00
Bogdan Nagirniak approved these changes 2023-09-22 10:02:44 +02:00
Bogdan Nagirniak left a comment
Collaborator

Looks good

Looks good
Bogdan Nagirniak merged commit 74afa9c393 into matx-export-material 2023-09-22 10:03:44 +02:00
Sign in to join this conversation.
No Label
No Milestone
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#27
No description provided.