DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

MaterialX: Fix group nodes. #32

Merged
Bogdan Nagirniak merged 3 commits from Vasyl-Pidhirskyi/blender:fix_group_nodes into matx-export-material 2023-09-22 18:37:41 +02:00
Conversation 0 Commits 3 Files Changed 1 +9 -2
Vasyl Pidhirskyi commented 2023-09-22 18:09:55 +02:00
Collaborator
Copy Link

Purpose

blender/blender#111765 (comment)

  • In the default startup .blend, putting the Principled BSDF node in a group doesn't seem to work here. The cube renders white instead of the specified base color.
  • The shader/node_group_color.blend renders white when it should be green, ignoring the color set on the group.

Technical steps

  • Specified to_type_ for GroupOutputNodeParser.
  • Improved GroupInputNodeParser::compute().
  • Improved GroupOutputNodeParser::compute().
### Purpose https://projects.blender.org/blender/blender/pulls/111765#issuecomment-1026764 * In the default startup .blend, putting the Principled BSDF node in a group doesn't seem to work here. The cube renders white instead of the specified base color. * The shader/node_group_color.blend renders white when it should be green, ignoring the color set on the group. ### Technical steps * Specified `to_type_` for `GroupOutputNodeParser`. * Improved `GroupInputNodeParser::compute()`. * Improved `GroupOutputNodeParser::compute()`.
Vasyl Pidhirskyi added 1 commit 2023-09-22 18:10:03 +02:00
180e021b6c Specified to_type. 
Improved GroupInputNodeParser::compute().
Improved GroupOutputNodeParser::compute().
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-09-22 18:10:08 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-09-22 18:10:09 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-09-22 18:10:15 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-09-22 18:10:16 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-09-22 18:10:16 +02:00
Vasyl Pidhirskyi self-assigned this 2023-09-22 18:10:17 +02:00
Georgiy Markelov approved these changes 2023-09-22 18:19:53 +02:00
Georgiy Markelov left a comment
Owner
Copy Link

Works fine.

Works fine.
Vasyl Pidhirskyi added 1 commit 2023-09-22 18:28:11 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-22 18:30:55 +02:00
Bogdan Nagirniak approved these changes 2023-09-22 18:37:09 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Works good

Works good
Bogdan Nagirniak merged commit 2e5b34b6ae into matx-export-material 2023-09-22 18:37:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#32
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender:fix_group_nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?