DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

MaterialX: code improvements #34

Merged
Bogdan Nagirniak merged 2 commits from matx-nodes-polishing into matx-export-material 2023-09-26 07:29:05 +02:00
Conversation 0 Commits 2 Files Changed 10 +44 -41
Georgiy Markelov commented 2023-09-25 16:39:31 +02:00
Owner
Copy Link

Purpose

Code improvements

Technical Steps

Comments fixes
PrinsipleBSDF: subsurface_radius type Vector3 -> Color3

### Purpose Code improvements ### Technical Steps Comments fixes `PrinsipleBSDF`: `subsurface_radius` type `Vector3` -> `Color3`
Georgiy Markelov added 1 commit 2023-09-25 16:39:55 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-09-25 16:42:31 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-09-25 16:42:31 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-09-25 16:42:31 +02:00
Bogdan Nagirniak approved these changes 2023-09-25 17:22:58 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Looks good + fix in subsurface_radius

Looks good + fix in subsurface_radius
Vasyl Pidhirskyi approved these changes 2023-09-25 18:27:24 +02:00
Vasyl Pidhirskyi approved these changes 2023-09-25 18:27:24 +02:00
Vasyl Pidhirskyi approved these changes 2023-09-25 18:27:25 +02:00
Georgiy Markelov added 1 commit 2023-09-25 18:34:44 +02:00
Brian Savery (AMD) approved these changes 2023-09-25 20:43:18 +02:00
Bogdan Nagirniak merged commit 2df0bc3670 into matx-export-material 2023-09-26 07:29:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Vasyl Pidhirskyi
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#34
No description provided.
Delete Branch "matx-nodes-polishing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?