DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

MaterialX: code improvements shader modes. #35

Merged
Bogdan Nagirniak merged 5 commits from Vasyl-Pidhirskyi/blender:matx-shader_nodes-polishing into matx-export-material 2023-09-26 11:02:40 +02:00
Conversation 2 Commits 5 Files Changed 7 +24 -40
Vasyl Pidhirskyi commented 2023-09-25 18:12:34 +02:00
Collaborator
Copy Link

Purpose

  • Code improvements.
  • Implemente Tangent Node.
  • Glass shader is over-reflected, make Glass shader node utilize only dielectric_bsdf with Reflection and Transmission components (scatter = RT).
    """dielectric_bsdf: A reflection/transmission BSDF node based on a microfacet model and a Fresnel curve for dielectrics."""
  • Sheen node Roughness input affects the node's effect.

Technical Steps

  • Code Improvements.
  • Comments fixes.
  • Implemented Tangent Node, using default tangent node.
  • Glass shader node: removed mixing with conductor_bsdf node as far as dielectric_bsdf node already has a reflection component so conductor_bsdf seems redundant.
  • Sheen node: removed weight input for sheen_bsdf, as far as it affects the node's effect.
  • Renamed Displacementshader -> DisplacementShader.
### Purpose * Code improvements. * Implemente Tangent Node. * Glass shader is over-reflected, make Glass shader node utilize only `dielectric_bsdf` with Reflection and Transmission components (scatter = RT). `"""dielectric_bsdf: A reflection/transmission BSDF node based on a microfacet model and a Fresnel curve for dielectrics."""` * Sheen node `Roughness` input affects the node's effect. ### Technical Steps * Code Improvements. * Comments fixes. * Implemented Tangent Node, using default `tangent` node. * Glass shader node: removed mixing with `conductor_bsdf` node as far as `dielectric_bsdf` node already has a reflection component so `conductor_bsdf` seems redundant. * Sheen node: removed `weight` input for `sheen_bsdf`, as far as it affects the node's effect. * Renamed Displacementshader -> DisplacementShader.
Vasyl Pidhirskyi self-assigned this 2023-09-25 18:12:35 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-09-25 18:12:35 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-09-25 18:12:35 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-09-25 18:12:35 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-25 18:12:44 +02:00 
Implemented Tangent node.
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-09-25 18:13:57 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-09-25 18:13:57 +02:00
Brian Savery (AMD) commented 2023-09-25 20:44:06 +02:00
Collaborator
Copy Link

This needs more explanation other than "code improvements".

This needs more explanation other than "code improvements".
Bogdan Nagirniak requested changes 2023-09-26 08:11:21 +02:00
source/blender/nodes/shader/materialx/node_item.cc Outdated
@ -327,7 +327,6 @@ NodeItem NodeItem::dotproduct(const NodeItem &other) const
NodeItem item1 = to_vector();
NodeItem item2 = other.to_vector();
cast_types(item1, item2);
Bogdan Nagirniak commented 2023-09-26 08:10:51 +02:00
Collaborator
Copy Link

Why this was removed?
Seems it could produce error when we try to do dotproduct vector2 by float or by vector3

Why this was removed? Seems it could produce error when we try to do dotproduct vector2 by float or by vector3
Vasyl Pidhirskyi commented 2023-09-26 08:28:56 +02:00
Author
Collaborator
Copy Link

Agree, reverted changes.

Agree, reverted changes.
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi commented 2023-09-26 08:21:25 +02:00
Author
Collaborator
Copy Link

This needs more explanation other than "code improvements".

Sure, updated the description.

> This needs more explanation other than "code improvements". Sure, updated the description.
Vasyl Pidhirskyi added 2 commits 2023-09-26 08:28:26 +02:00
Bogdan Nagirniak approved these changes 2023-09-26 09:30:19 +02:00
Bogdan Nagirniak left a comment
Collaborator
Copy Link

Looks good

Looks good
Vasyl Pidhirskyi added 1 commit 2023-09-26 10:37:14 +02:00
Vasyl Pidhirskyi added 1 commit 2023-09-26 10:48:45 +02:00
Bogdan Nagirniak approved these changes 2023-09-26 11:01:26 +02:00
Bogdan Nagirniak merged commit 2e741c6825 into matx-export-material 2023-09-26 11:02:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Vasyl Pidhirskyi
Bogdan Nagirniak
Brian Savery (AMD)
Georgiy Markelov
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#35
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender:matx-shader_nodes-polishing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?