DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

MaterialX: code improvements shader modes. #35

Merged
Bogdan Nagirniak merged 5 commits from Vasyl-Pidhirskyi/blender:matx-shader_nodes-polishing into matx-export-material 2023-09-26 11:02:40 +02:00
Conversation 2 Commits 5 Files Changed 7 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fbc05db737 - Show all commits

1
source/blender/nodes/shader/materialx/node_item.cc
View File

@ -327,6 +327,7 @@ NodeItem NodeItem::dotproduct(const NodeItem &other) const
NodeItem item1 = to_vector();
NodeItem item2 = other.to_vector();
cast_types(item1, item2);
return create_node("dotproduct", Type::Float, {{"in1", item1}, {"in2", item2}});
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Bogdan Nagirniak commented 2023-09-26 08:10:51 +02:00
Outdated
Review
Copy Link

Why this was removed?
Seems it could produce error when we try to do dotproduct vector2 by float or by vector3

Why this was removed? Seems it could produce error when we try to do dotproduct vector2 by float or by vector3
Vasyl Pidhirskyi commented 2023-09-26 08:28:56 +02:00
Outdated
Review
Copy Link

Agree, reverted changes.

Agree, reverted changes.
}