DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

matx-code-improvements #8

Merged
Bogdan Nagirniak merged 6 commits from BogdanNagirniak/blender:matx-code-improvements into matx-export-material 2023-09-04 10:10:09 +02:00
Conversation 0 Commits 6 Files Changed 13 +175 -123
Bogdan Nagirniak commented 2023-09-02 01:37:13 +02:00
Collaborator
Copy Link

Purpose

There is set of code improvements and bug fixes required in NodeParser system.

Technical steps

  1. Separated OutputMaterialNodeParser declaration to output_material.h. Added more functionality.
  2. Added NodeParser::compute_full() with additional logging and naming of mx_node.
  3. Fix: added check if node was already computed.
  4. Fixed TexChecker.
  5. Code improvements, renamings, code cleanup.

Notes

There is no need additional scaling in TexChecker, it was removed. There is issue with UV map on default cube, which should be fixed another way.

### Purpose There is set of code improvements and bug fixes required in NodeParser system. ### Technical steps 1. Separated `OutputMaterialNodeParser` declaration to `output_material.h`. Added more functionality. 2. Added `NodeParser::compute_full()` with additional logging and naming of mx_node. 3. Fix: added check if node was already computed. 4. Fixed TexChecker. 5. Code improvements, renamings, code cleanup. ### Notes There is no need additional scaling in TexChecker, it was removed. There is issue with UV map on default cube, which should be fixed another way.
Bogdan Nagirniak added 6 commits 2023-09-02 01:37:36 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-09-02 01:37:43 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-09-02 01:37:43 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-09-02 01:37:50 +02:00
Bogdan Nagirniak self-assigned this 2023-09-02 01:37:50 +02:00
Georgiy Markelov approved these changes 2023-09-04 10:07:07 +02:00
Georgiy Markelov left a comment
Owner
Copy Link

Works fine.

Works fine.
Bogdan Nagirniak merged commit e1248d2f28 into matx-export-material 2023-09-04 10:10:09 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#8
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-code-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?