Zijun Zhou Eary
  • Joined on 2019-09-02
Zijun Zhou commented on pull request blender/blender#106355 2023-07-06 17:24:56 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Ok I see what you are doing.

Note that by adding the AgX - prefix, the looks won't show up under AgX Log, Guard Rail, ect.

But this doesn't sound ideal. I would like AgX Log and `Guard…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-06 16:52:56 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Thanks but again the current situation is:

image Both Filmic Looks and AgX Looks are present at the same time when choosing Filmic,…

Zijun Zhou commented on pull request blender/blender#106355 2023-06-22 09:59:27 +02:00
Replace Default OCIO config with AgX (Filmic v2)

@brecht @pablovazquez I want to get some comfirmation, is there another dev in charge of the UI that can help with the Filmic Looks' view-based filtering? I honestly have no idea how to change the…

Zijun Zhou commented on pull request blender/blender#106355 2023-06-02 21:42:24 +02:00
Replace Default OCIO config with AgX (Filmic v2)

So I think that simply adding AgX to the View Transforms is better than outright replacing Filmic. It's not like we've got that many options to choose from right now anyway.

Not sure what we…

Zijun Zhou commented on pull request blender/blender#106355 2023-06-01 01:14:53 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Adding back Filmic to the view transform menu was requested by Brecht, I believe the idea is to have old .blend files being kept completely the same as before, to make it able to auto select…

Zijun Zhou commented on pull request blender/blender#106355 2023-05-31 08:00:25 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I made AgX False Color completely from scratch, with our previous conversation about False Color in mind. Specifically, previous False Color has some problem with the luminance coefficients being…

Zijun Zhou commented on pull request blender/blender#106355 2023-05-19 17:39:06 +02:00
Replace Default OCIO config with AgX (Filmic v2)

It is actually intensional, the intension of false color in the first place is to posterize for better visualization of different ranges.

Zijun Zhou commented on pull request blender/blender#106355 2023-05-11 16:09:10 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Or if we can delay it to 4.0 or some version where we can drop some backwards campatibility, in that case we can just drop the support for Filmic Looks. It's not that the new contrast looks are…

Zijun Zhou commented on pull request blender/blender#106355 2023-05-10 16:45:44 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Just for the record, AgX is perfectly ready in my view point, the only thing I am waiting for is the code change that Brecht mentioned, so that we can bring back Filmic Looks. After that, at least…

Zijun Zhou commented on pull request blender/blender#106355 2023-05-03 02:56:35 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Standard while using the AgX config does is very slightly less precise than in Vanilla Blender

It's not "less precise", I have already mentioned before but again, it's a design decision…

Zijun Zhou commented on issue blender/blender#105714 2023-04-28 18:45:16 +02:00
Supporting HDR workflows in Blender
  • Change OCIO config so view transforms go to an intermediate color space (cie_xyz_d65_interchange) rather than directly to the final color space.

I thought about doing this when making the…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-27 04:55:58 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I updated the LUTs to improve the LUT precision.

Zijun Zhou closed issue blender/blender#103470 2023-04-20 22:31:53 +02:00
Add View Transform space to inactive_colorspaces Causes extra transform when saving 16 bit PNG
Zijun Zhou commented on issue blender/blender#107064 2023-04-20 22:30:47 +02:00
OpenColorIO implementation gamma problem.

Just want to mention I reported the exact same thing months ago, nobody even cared. Not sure why it's suddenly fixed.

Zijun Zhou commented on pull request blender/blender#106355 2023-04-03 14:01:39 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Tester has reported posterization in wider gamut after the matrix commit. Will revert it.

Zijun Zhou commented on pull request blender/blender#106355 2023-04-03 09:14:47 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I tried some method to minimize the precision error, now the error should be extremely small. Welcome testing.

Zijun Zhou commented on pull request blender/blender#106355 2023-04-03 00:40:06 +02:00
Replace Default OCIO config with AgX (Filmic v2)

The 2.2 EOTF is already out of the LUT. Remapping before and after the LUT is already there as well, I decided not to use the log 2 curve because people reported the log 2 curve caused a shift of…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-02 10:48:57 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I don't understand how it can be both exactly the same as standard in the [0.0, 1.0] range, and still give significantly different Hex colors which are always within the [0.0, 1.0] range.

Agai…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-02 10:16:45 +02:00
Replace Default OCIO config with AgX (Filmic v2)

It's not clear to me what Guard Rail does and what its purpose is, the name or description does not make it clear to me.

Guard Rail's design principal is to keep the valid range of [0.0, 1.0]…

Zijun Zhou commented on pull request blender/blender#106355 2023-04-02 07:37:36 +02:00
Replace Default OCIO config with AgX (Filmic v2)

I just added a hack to compensate for Guard Rail sRGB's chroma lost from LUT precision. Plus added back the Legacy Standard, the issue reguarding that should be over now.