Amine Bensalem HamilcarR
0 Followers · 0 Following
  • Joined on 2023-09-08
Repositories
1
 Projects Public Activity Starred Repositories
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-10-17 23:32:54 +02:00
ea000acfb8 Cleanup: Format comment
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-10-17 23:22:22 +02:00
6eccfde446 Refractor #108728: Removed now unused socket creation code.
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-10-17 23:16:13 +02:00
37d245926e Refractor #108728: Removed now unused socket creation code.
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-10-17 23:05:26 +02:00
48fe6118aa Fix: Missing link in default compositor configuration
8e3f921362 Cleanup: Removed call to node_type_storage()
1f91280585 Cleanup : Removed useless assert
028e99541e Refractor : Removed call to node_cmp_rlayers_outputs
c8c57b31db Cleanup : Removed unused function declarations
Compare 9341 commits »
Amine Bensalem pushed to main at HamilcarR/blender 2024-10-17 00:54:28 +02:00
36c9aea35a Merge branch 'blender-v4.3-release'
9222ce24f5 Cleanup: make format
0b2f65c665 Merge branch 'blender-v4.3-release'
b2a333a0cc Libs: macOS arm64/x64: Update autopep8 to 2.3.1
9b78b8d1ed UI: Fix and improve a few messages
Compare 14651 commits »
Amine Bensalem commented on issue blender/blender#118325 2024-06-11 20:14:52 +02:00
Cycles: Objects are invisible in viewport when an object scale is 0

Does the viewport use more precision than the final render somewhere?

Not from what I've seen , but I could have missed something, I don't know embree that well .
They do use two different…

Amine Bensalem commented on issue blender/blender#118325 2024-06-11 15:06:11 +02:00
Cycles: Objects are invisible in viewport when an object scale is 0

Hi @HamilcarR, It was broken in every version that I tested, down to 3.3.1.

But it only happens in CPU mode, not when using GPU Compute in the Cycles Render Properties

Yeah , the…

Amine Bensalem commented on pull request blender/blender#123054 2024-06-11 10:24:22 +02:00
WIP: Fix #118325: Fixes missing ray hits in Cycles viewport.

When making a pull request, it's best to limit changes to only the area you're working on. This means adjusting IntegratorStateCPU in /intern/cycles/integrator/path_trace_work_cpu.cpp…

Amine Bensalem commented on issue blender/blender#118325 2024-06-11 09:05:45 +02:00
Cycles: Objects are invisible in viewport when an object scale is 0

@max-mustermann hi , you indicated that some version of blender worked as intended , can you tell me which one it is ?

Amine Bensalem created pull request blender/blender#123054 2024-06-11 08:23:15 +02:00
WIP: Fix #118325: Fixes missing ray hits in Cycles viewport.
Amine Bensalem created branch Fix-118325 in HamilcarR/blender 2024-06-11 08:20:32 +02:00
Amine Bensalem pushed to Fix-118325 at HamilcarR/blender 2024-06-11 08:20:32 +02:00
c86740bf3a Fix #118325: Fixes missing ray hits in Cycles viewport.
1c92d26bfc PyAPI Doc: fix typos causing untyped parameters
8719057b4a Cleanup: unused arguments and warnings raised by pylint
17ec64770c Extensions: ensure paths are always included for the "build" command
b15dc90c9d Fix #119282: Enable edge-pan when duplicating nodes from menu
Compare 10 commits »
Amine Bensalem deleted branch Fix-118325 from HamilcarR/blender 2024-06-11 08:19:56 +02:00
Amine Bensalem pushed to Fix-118325 at HamilcarR/blender 2024-06-11 08:18:35 +02:00
c86740bf3a Fix #118325: Fixes missing ray hits in Cycles viewport.
Amine Bensalem created branch Fix-118325 in HamilcarR/blender 2024-06-11 08:11:21 +02:00
Amine Bensalem pushed to Fix-118325 at HamilcarR/blender 2024-06-11 08:11:21 +02:00
894d33575c Fix #118325: Fixes missing ray hits in Cycles viewport.
7806674427 Corrected typo
b58967edca Initialize Integrator states
1c92d26bfc PyAPI Doc: fix typos causing untyped parameters
8719057b4a Cleanup: unused arguments and warnings raised by pylint
Compare 10 commits »
Amine Bensalem commented on issue blender/blender#118325 2024-06-05 10:25:32 +02:00
Cycles: Objects are invisible in viewport when an object scale is 0

taking this one

Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2024-04-29 20:30:06 +02:00
edfceb0a67 Fixed inverted scale tilt
6f4c5c0d23 Merge branch 'main' into cycles-114780_chiang-hair
679a05a02c Core: lib_query: Replace raw function pointer by FunctionRef for callback.
de7ea7e60d Fix: don't allow zero bandwidth in sdf grid
dafcb353b8 Fix #120950: Graph Editor curve drawing artifacts with normalized display
Compare 2715 commits »
Amine Bensalem commented on pull request blender/blender#115241 2024-04-29 19:24:53 +02:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

Thank you! Sorry for the delay, somehow this PR totally slipped my attention.

The implementation looks mostly correct, however, it totally negated the behaviour of scale tilt, that's not…

Amine Bensalem commented on pull request blender/blender#115241 2024-04-29 19:22:13 +02:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

agreed , this was poorly named.