Amine Bensalem HamilcarR
0 Followers · 0 Following
  • Joined on 2023-09-08
Repositories
1
 Projects Public Activity Starred Repositories
Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2024-04-29 20:30:06 +02:00
edfceb0a67 Fixed inverted scale tilt
6f4c5c0d23 Merge branch 'main' into cycles-114780_chiang-hair
679a05a02c Core: lib_query: Replace raw function pointer by FunctionRef for callback.
de7ea7e60d Fix: don't allow zero bandwidth in sdf grid
dafcb353b8 Fix #120950: Graph Editor curve drawing artifacts with normalized display
Compare 2715 commits »
Amine Bensalem commented on pull request blender/blender#115241 2024-04-29 19:24:53 +02:00
Fix #114780: Cycles: Importance sampling correction

Thank you! Sorry for the delay, somehow this PR totally slipped my attention.

The implementation looks mostly correct, however, it totally negated the behaviour of scale tilt, that's not…

Amine Bensalem commented on pull request blender/blender#115241 2024-04-29 19:22:13 +02:00
Fix #114780: Cycles: Importance sampling correction

agreed , this was poorly named.

Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-04-25 15:37:52 +02:00
8130de9fa4 Cleanup
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-04-25 15:08:32 +02:00
20474ebec9 Refactor: replaced edit_mesh from mesh runtime structure
a3de8da6d3 Merge branch 'main' into UI-104092_show_indices_uv_editor
679a05a02c Core: lib_query: Replace raw function pointer by FunctionRef for callback.
de7ea7e60d Fix: don't allow zero bandwidth in sdf grid
dafcb353b8 Fix #120950: Graph Editor curve drawing artifacts with normalized display
Compare 2409 commits »
Amine Bensalem commented on pull request blender/blender#118746 2024-03-10 21:38:02 +01:00
UVEditor: Display mesh indices

Hi @Jeroen-Bakker , Do you want to review this ?

Amine Bensalem commented on pull request blender/blender#114629 2024-03-10 21:35:31 +01:00
WIP: Refractor: Compositor: Render layer node to dynamic declaration

Unfortunately, the default compositor setup is now invalid: the link between render layers node and the output is missing. This seems to be caused by the fact that in the old system the render…

Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-05 23:08:43 +01:00
63355eedf4 Cleanup
d90e5d19a9 Cleanup
Compare 2 commits »
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-05 13:00:03 +01:00
876357a728 indices option now doesn't appear in texture paint mode
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-05 00:31:05 +01:00
c61af7e6c2 Cleanup
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-05 00:22:44 +01:00
6a2d9833ea Added Indices button on the UV editor overlay panel
f315a87d6d Displays vert/edge/face IDs using UV sync selection in addition
c4db5e8aca Cleanup : removed unused lookup map
6b0af4df59 Cleanup : removed unused headers
Compare 4 commits »
Amine Bensalem commented on pull request blender/blender#118746 2024-03-04 14:30:44 +01:00
UVEditor: Display mesh indices

Each editor should have its own toggle buttons to enable/disable the indices. Similar to the 3d viewport.

Okay. Also ... This may not be in the scope of the issue but : On the UV , the…

Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-04 10:53:24 +01:00
15c09f0086 Implemented face indices display on UV editor
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-04 10:35:37 +01:00
d89a9e861b Moved uv measure indice display to draw_manager_text.cc
Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-03-03 20:40:30 +01:00
ed0d0cb848 Reformating
79a5537a04 Implemented edge indices display
Compare 2 commits »
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-03-01 12:30:18 +01:00
5f6bfb219d format
4748727b7e Merge branch 'main' into nodes-108728-cmp_node_r_layers
b29d2a3815 image and alpha sockets created only with RE_PASSNAME_COMBINED
c2b56ca468 Cleanup: prevent unnecessary copy of VArray
1e20f06c21 BLI: add utility to simplify creating proper random access iterator
Compare 328 commits »
Amine Bensalem commented on pull request blender/blender#114629 2024-02-28 20:24:22 +01:00
WIP: Refractor: Compositor: Render layer node to dynamic declaration

sorry I didn't see the update , this one slipped through indeed

Amine Bensalem commented on pull request blender/blender#114629 2024-02-28 19:42:30 +01:00
WIP: Refractor: Compositor: Render layer node to dynamic declaration

So to match the old code the patch needs to inly add Image and Alpha if there is Combined pass in the render engine.

Thank you for the feedback . By this , do you mean checking the presence…

Amine Bensalem pushed to UI-104092_show_indices_uv_editor at HamilcarR/blender 2024-02-27 07:03:56 +01:00
c4f2d7785e Implemented vertex indices display on UV editor
Amine Bensalem created pull request blender/blender#118746 2024-02-26 13:30:02 +01:00
WIP: Feature #104092 : Display mesh indices in the UV editor