Hombre57
  • Metz, FRANCE
  • Joined on 2024-05-30
Hombre57 created pull request extensions/io_scene_x3d#6 2024-07-21 11:05:07 +02:00
Fix per vertex normals and colors import
Hombre57 created branch per-vertex_normals_and_colors in Hombre57/io_scene_x3d 2024-07-21 10:51:16 +02:00
Hombre57 pushed to per-vertex_normals_and_colors at Hombre57/io_scene_x3d 2024-07-21 10:51:16 +02:00
fd2106afa5 Fix per vertex normals and colors import
Hombre57 created repository Hombre57/io_scene_x3d 2024-07-20 20:52:02 +02:00
Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-07-20 16:31:49 +02:00
fix list index out of range for color_per_vertex

@Bujus_Krachus

In short :

// Test will be fast for correct files, more time consuming for broken files
if ('-1' not in color_index)
   // Build a temporary list and place '-1' at the…
Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-07-20 15:46:17 +02:00
fix list index out of range for color_per_vertex

@Bujus_Krachus Here are some files. The screenshots are taken after importing the "corrected" version.

Hombre57 commented on pull request extensions/io_scene_x3d#2 2024-07-20 14:56:12 +02:00
fix list index out of range for color_per_vertex

Have you tested your patch with a correctly formed VRML patch, i.e. with face vertex color index ending with '-1' like other per vertex nodes does ?

http://graphcomp.com/info/specs/sgi/vrml/spec

Hombre57 commented on issue blender/blender-addons#105398 2024-07-20 14:33:20 +02:00
VRML Import Error

@G-10 The VRML file you provided does not respect the standard, see here http://graphcomp.com/info/specs/sgi/vrml/spec/part1/nodesRef.html#IndexedFaceSet :

If the color field is not NULL then…