Hoshinova
1 Followers · 0 Following
  • Joined on 2023-04-11
Repositories
1
 Projects Public Activity Starred Repositories
1
Hoshinova commented on pull request blender/blender#109255 2023-06-23 13:40:35 +02:00
Fix #109253

@OmarEmaraDev Commit message:

Fix: Voronoi Smooth F1 breaking when Smoothness is set to 0.0 in OSL

The Voronoi node now calls the F1 functions instead of Smooth F1
when Smoothness is…
Hoshinova commented on pull request blender/blender#109255 2023-06-23 13:36:25 +02:00
Fix #109253

What do you mean by "Separate the cleanup changes"?

Hoshinova commented on pull request blender/blender#109286 2023-06-23 13:12:56 +02:00
Fix #109254: Voronoi Distance Output Clamps at 8.0 with low Minkowski Exponents

The problem with Smooth F1 is that the 8.0 seems to be the only constant where the smooth interpolation works correctly. So I thought you might know how to change the interpolation logic to make…

Hoshinova created pull request blender/blender#109286 2023-06-23 13:09:42 +02:00
WIP: Fix #109254
Hoshinova pushed to db at Hoshinova/blender 2023-06-23 13:07:52 +02:00
57a62a0787 -- Fix F1 and F2 clamping at 8.0
Hoshinova created branch db in Hoshinova/blender 2023-06-23 13:07:52 +02:00
Hoshinova commented on pull request blender/blender#109255 2023-06-23 12:57:21 +02:00
Fix #109253

@OmarEmaraDev This is only #109253 now. I think it can be merged as is.

Hoshinova pushed to wb at Hoshinova/blender 2023-06-23 12:54:43 +02:00
e9c6cf6d3d -- Only fix #109253
Hoshinova reopened pull request blender/blender#109255 2023-06-23 12:52:56 +02:00
Fix #109253
Hoshinova closed pull request blender/blender#109255 2023-06-23 12:52:43 +02:00
Fix #109253
Hoshinova commented on pull request blender/blender#109255 2023-06-23 12:52:42 +02:00
Fix #109253

Sure

Hoshinova commented on pull request blender/blender#109255 2023-06-23 11:45:39 +02:00
Fix #109253

Right, we can just use params.max_distance here.

The problem with Smooth F1 is that the 8.0 seems to be the only constant where the smooth interpolation works correctly. So I thought you…

Hoshinova commented on pull request blender/blender#109255 2023-06-23 00:39:57 +02:00
Fix #109253

@OmarEmeraDev I can't find a quick fix for #109254 for Smooth F1. Could you please specifout of all people you

Hoshinova commented on pull request blender/blender#109255 2023-06-22 21:04:52 +02:00
Fix #109253

I just noticed that the fix for #109254 breaks Smooth F1 when changing 8.0 to 8000000000.0 here: b1f7c87b99/sou…

Hoshinova pushed to wb at Hoshinova/blender 2023-06-22 21:00:02 +02:00
c851a3deac -- Roll back Smooth F1 clamping limit fix.
Hoshinova commented on pull request blender/blender#109255 2023-06-22 20:02:03 +02:00
Fix #109253

Ok, good to know. Thanks

Hoshinova commented on pull request blender/blender#109255 2023-06-22 19:52:24 +02:00
Fix #109253

@OmarEmaraDev I think that the issue in blender/blender#109253 is caused by a division by zero in https://projects.blender.org/blender/blender/src/commit/c1e7c02…

Hoshinova created pull request blender/blender#109255 2023-06-22 19:45:11 +02:00
WIP: Fix https://projects.blender.org/blender/blender/issues/109253 and partially fix https://projects.blender.org/blender/blender/issues/109254
Hoshinova opened issue blender/blender#109254 2023-06-22 19:40:52 +02:00
Voronoi Distance Output Clamps at 8.0 with low Minkowski Exponents
Hoshinova opened issue blender/blender#109253 2023-06-22 19:36:15 +02:00
OSL Voronoi Smooth F1 breaks when Smoothness is set to 0.0