Jacques Lucke JacquesLucke
28 Followers · 0 Following
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Overview Repositories
14
 Projects Public Activity Starred Repositories
1
Jacques Lucke merged pull request blender/blender#128128 2024-09-26 12:59:21 +02:00
Attributes: improve API to iterate over attributes
Jacques Lucke suggested changes for blender/blender#127892 2024-09-26 12:58:13 +02:00
Fix: Show nothing in spreadsheet when the property is a string property
Jacques Lucke commented on pull request blender/blender#127892 2024-09-26 12:58:12 +02:00
Fix: Show nothing in spreadsheet when the property is a string property

Use static_cast. Same below.

Jacques Lucke commented on pull request blender/blender#127892 2024-09-26 12:58:11 +02:00
Fix: Show nothing in spreadsheet when the property is a string property

Seems like using StringRef instead of std::string should work here. No need to make an unnecessary copy of the data.

Jacques Lucke pushed to main at blender/blender 2024-09-26 12:54:25 +02:00
63a6ff3008 Fix #128144: crash when rendering generated volume
Jacques Lucke closed issue blender/blender#128144 2024-09-26 12:54:23 +02:00
GeoNodes: Mesh/Points to Volume crash in Render Preview (Cycles only)
Jacques Lucke approved blender/blender#128147 2024-09-26 12:28:30 +02:00
Refactor: move BLI_path_util header to C++, rename to BLI_path_utils
Jacques Lucke commented on pull request blender/blender#128123 2024-09-26 12:26:30 +02:00
Fix #128102: Integer Math division has only float precision

@blender-bot build

Jacques Lucke approved blender/blender#128123 2024-09-26 12:26:17 +02:00
Fix #128102: Integer Math division has only float precision
Jacques Lucke commented on pull request blender/blender#128123 2024-09-26 12:20:49 +02:00
Fix #128102: Integer Math division has only float precision

ok, fine with me, it would just be nice to have some kinds of test here, a regression test can be ok as well though.

Jacques Lucke commented on pull request blender/blender#128128 2024-09-26 12:09:40 +02:00
Attributes: improve API to iterate over attributes

@blender-bot build

Jacques Lucke pushed to foreach-attribute-iterator at JacquesLucke/blender 2024-09-26 12:09:20 +02:00
6e3c78ba0d improve comment
1299b0f555 Merge branch 'main' into foreach-attribute-iterator
d10db547a7 Fix: Assert drawing GPv3 outline stroke
70313f68ce Vulkan: Log selected device
88b5467e0e Vulkan: Batch Upload Descriptor Sets
Compare 46 commits »
Jacques Lucke suggested changes for blender/blender#128123 2024-09-25 17:53:17 +02:00
Fix #128102: Integer Math division has only float precision
Jacques Lucke commented on pull request blender/blender#128123 2024-09-25 17:53:16 +02:00
Fix #128102: Integer Math division has only float precision

Would be good to extract that into a separate function in blenlib and to add some unit tests for it. (e.g. in BLI_math_base_safe_test.cc)

Jacques Lucke commented on pull request blender/blender#128123 2024-09-25 17:53:15 +02:00
Fix #128102: Integer Math division has only float precision

Isn't this the same as the math::safe_divide?

Jacques Lucke commented on pull request blender/blender#128128 2024-09-25 17:42:30 +02:00
Attributes: improve API to iterate over attributes

@blender-bot build

Jacques Lucke created pull request blender/blender#128128 2024-09-25 17:41:22 +02:00
Attributes: improve API to iterate over attributes
Jacques Lucke pushed to foreach-attribute-iterator at JacquesLucke/blender 2024-09-25 17:36:53 +02:00
ee289d8d9a cleanup
Jacques Lucke pushed to foreach-attribute-iterator at JacquesLucke/blender 2024-09-25 17:33:27 +02:00
568d382ea9 progress
6028f7d035 progress
75b9fb18ac progress
976406bd97 progress
e452d42ecc progress
Compare 32 commits »
Jacques Lucke commented on issue blender/blender#128109 2024-09-25 16:19:08 +02:00
Material Selection Node is not working with Grease Pencil

That should work in theory, but I'm not sure if the Material Selection node supports curves yet (it should though).