Jonas Dichelle JonasDichelle
  • Germany
  • Joined on 2018-03-27
Jonas Dichelle pushed to vectorscope-update at JonasDichelle/blender 2024-02-06 10:27:55 +01:00
24b7efa648 fixed formatting issues
Jonas Dichelle commented on pull request blender/blender#116974 2024-02-02 11:42:45 +01:00
Image Editor Vectorscope Improvement

The code looks alright to me. Might be worth rebasing or merging latest main though.

Done, thanks for reviewing it!

Jonas Dichelle pushed to vectorscope-update at JonasDichelle/blender 2024-02-02 11:37:53 +01:00
8ecf051684 Merge branch 'main' of projects.blender.org:blender/blender into vectorscope-update
fa5f1b3a9c Fix building errors
adb304f0ed Extensions: improve UI for adding/removing repositories
7d3003be4d Geometry Nodes: store bake item names on disk
31df006b39 UI: Two Misc Prop Dialog Title Changes
Compare 633 commits »
Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 21:03:09 +01:00
Image Editor Vectorscope Improvement

@aras_p Very cool, it looks a lot better especially compared to 4.0!

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 16:37:51 +01:00
Image Editor Vectorscope Improvement

Yes we can do that updated it in the latest commit!

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 16:37:08 +01:00
Image Editor Vectorscope Improvement

i updated it in 2bebddf117

Jonas Dichelle pushed to vectorscope-update at JonasDichelle/blender 2024-02-01 16:35:03 +01:00
2bebddf117 minor code changes
Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 16:22:51 +01:00
Image Editor Vectorscope Improvement

Good call, I'll change that!

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 16:13:52 +01:00
Image Editor Vectorscope Improvement

I did this because we need to pass in 4 values for each Vertex into the shader. Having individual alphas for each vertex is necessary to get good looking accumulation. If we didn't do this here…

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 16:08:39 +01:00
Image Editor Vectorscope Improvement

I agree RGB would be better. I just copied the label from the Waveform which has "Red Green Blue". But I'm also in favor of changing this.

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 12:41:00 +01:00
Image Editor Vectorscope Improvement

Cool, I pushed the new version. I only added it to the luma mode since it looked…

Jonas Dichelle pushed to vectorscope-update at JonasDichelle/blender 2024-02-01 12:40:49 +01:00
30e016c1f7 Added colorwheel to background for luma version
Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 11:48:10 +01:00
Image Editor Vectorscope Improvement

Yes, I just tested it and was going to add that it actually looks quite good even if not entirely accurate and might be good enough.

![blender_HCrrP0ciRv.png](/attachments/1061780e-bdd2-4c8f-b5d…

Jonas Dichelle commented on pull request blender/blender#116974 2024-02-01 10:55:16 +01:00
Image Editor Vectorscope Improvement

@aras_p, I've thought about that too. But in that case, you wouldn't, for example, have an accurate loss of saturation towards the center. If you wanted to accurately represent the colors in the…

Jonas Dichelle commented on pull request blender/blender#116974 2024-01-31 21:45:09 +01:00
Image Editor Vectorscope Improvement

Would it help to add GPU_line_smooth(true); in the mix for better anti aliasing? Or am I wishful thinking here. Thanks!

Oh wow, that look a lot better! I like the way it looks a lot…

Jonas Dichelle pushed to vectorscope-update at JonasDichelle/blender 2024-01-31 21:45:07 +01:00
4be5c04f5f Made circle look nicer
Jonas Dichelle commented on pull request blender/blender#116974 2024-01-31 18:04:01 +01:00
Image Editor Vectorscope Improvement

@pablovazquez, thank you for the feedback! Changing the line width is pretty easy. Here's a screenshot with GPU_line_width(2.0f): ![blender_uPBS5Eu1uz.png](/attachments/e5e2a6e9-0dcb-45b6-9444-…

Jonas Dichelle pushed to vectorscope-refactor at JonasDichelle/blender 2024-01-30 17:19:33 +01:00
236881ff9c Anim: Armature, move notifiers from setters to updaters
f2e7f26072 UI: Tree view, no longer auto-expand clicked item
c87f235598 Cleanup: make format
8d4643af63 Fix: GPv3: Don't ignore influence in thickness modifier
35f949531f Cleanup: Fix warning of deprecated value in Paint struct
Compare 500 commits »
Jonas Dichelle pushed to vectorscope-refactor at JonasDichelle/blender 2024-01-30 17:17:52 +01:00
Jonas Dichelle created branch vectorscope-refactor in JonasDichelle/blender 2024-01-30 17:17:52 +01:00