Joseph Eagar JosephEagar
9 Followers · 0 Following
  • Sacramento, California, USA
  • Joined on 2004-09-20
Repositories
1
 Projects Public Activity Starred Repositories
Joseph Eagar commented on pull request blender/blender#107458 2023-05-01 22:19:16 +02:00
Fix #107123: Refactor sculpt normal calculation to require vert poly map

Use verts_to_update or the node unique verts to clear the update tags.

Joseph Eagar commented on pull request blender/blender#107458 2023-05-01 00:27:40 +02:00
Fix #107123: Refactor sculpt normal calculation to require vert poly map

The list doesn't have to be unique btw, there's no point going through the effort to eliminate duplicates.

Joseph Eagar suggested changes for blender/blender#107458 2023-04-29 23:21:29 +02:00
Fix #107123: Refactor sculpt normal calculation to require vert poly map
Joseph Eagar commented on pull request blender/blender#107458 2023-04-29 23:21:28 +02:00
Fix #107123: Refactor sculpt normal calculation to require vert poly map

We can't afford to iterate over all the verts of the mesh here. It's better to build a list of verts to update from the PBVH nodes.

Joseph Eagar pushed to temp-pbvh-normals at blender/blender 2023-04-29 11:35:48 +02:00
9507494675 Merge branch 'main' into temp-pbvh-normals
ca00cb5470 Cleanup: format
d145dfdae0 Fix #107443 movie clip fails to load
Compare 3 commits »
Joseph Eagar pushed to temp-pbvh-normals at blender/blender 2023-04-29 11:35:27 +02:00
3bc6374267 temp-pbvh-normals: Make requested patch changes
0328886f98 Merge branch 'main' into temp-pbvh-normals
2d2f4d9d28 Cleanup: Rename StrokeCache.original to .accum
15d2487e26 Sculpt: Fix #105303: improper setting of SculptCache.original
Compare 4 commits »
Joseph Eagar commented on pull request blender/blender#107456 2023-04-29 11:28:30 +02:00
Sculpt: Fix #107123: New normals impl. for PBVH_FACES

Shouldn't that be Span<const PBVHNode*>?

Joseph Eagar commented on pull request blender/blender#107456 2023-04-29 11:27:02 +02:00
Sculpt: Fix #107123: New normals impl. for PBVH_FACES

That assumption doesn't really hold, and I don't think using the nodes size as a heuristic really works. You'd have to multiply it by some factor (a percentage of the leaf limit most likely)…

Joseph Eagar pushed to main at blender/blender 2023-04-29 02:59:35 +02:00
2d2f4d9d28 Cleanup: Rename StrokeCache.original to .accum
Joseph Eagar pushed to main at blender/blender 2023-04-29 02:54:27 +02:00
15d2487e26 Sculpt: Fix #105303: improper setting of SculptCache.original
Joseph Eagar closed issue blender/blender#105303 2023-04-29 02:54:26 +02:00
Regression: View/Area Auto-Masking breaks Accumulate Setting
Joseph Eagar commented on issue blender/blender#106895 2023-04-29 02:32:10 +02:00
Sculpt Mode: Tip Roundness on Paint brush scales texture outside of bounds

Is this still happening?

Joseph Eagar pushed to temp-pbvh-normals at blender/blender 2023-04-29 02:17:27 +02:00
93d095906e temp-pbvh-normals: Comment out unused parameter
Joseph Eagar commented on issue blender/blender#107123 2023-04-29 02:13:00 +02:00
Sculpt Mode: Smooth Normals don't properly update while sculpting

See pull request #107456

Joseph Eagar pushed to temp-pbvh-normals at blender/blender 2023-04-29 02:11:52 +02:00
3755f4fcda temp-pbvh-normals: commit patch
Joseph Eagar created pull request blender/blender#107456 2023-04-29 02:10:10 +02:00
Sculpt: Fix #107123: New normals impl. for PBVH_FACES
Joseph Eagar pushed to temp-pbvh-normals at blender/blender 2023-04-29 01:52:48 +02:00
Joseph Eagar created branch temp-pbvh-normals in blender/blender 2023-04-29 01:52:47 +02:00
Joseph Eagar commented on issue blender/blender#107123 2023-04-27 23:36:59 +02:00
Sculpt Mode: Smooth Normals don't properly update while sculpting

To solve this we need to update not just the marked vertices but the first topological ring around them too. The current PBVH_FACES normal calc code cannot handle this since there is no way to get…

Joseph Eagar deleted branch mempool_asan from JosephEagar/blender 2023-04-26 10:36:41 +02:00